Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux: unable to exit config editor on inbrowser.tld #289

Open
lidel opened this issue Jun 10, 2024 · 4 comments
Open

ux: unable to exit config editor on inbrowser.tld #289

lidel opened this issue Jun 10, 2024 · 4 comments
Assignees

Comments

@lidel
Copy link
Member

lidel commented Jun 10, 2024

Problem

If I open https://inbrowser.dev and click on config editor:

2024-06-10_15-25

There is no way to close editor and go back to the main screen where i can enter the content path, i am stuck in config editor and have to manually edit URL in address bar:

2024-06-10_15-22

Fix ideas

  • make clickin "Save config" collapse config when embedded on Iframe and remove /#/ipfs-sw-config from URL if not in iframe (on main domain)
  • Or keep "Save Config" as-is and add dedicated "Close" button that does the above.
@lidel lidel added this to the IPFS Camp 2024 milestone Jun 10, 2024
@lidel lidel changed the title ux: unable to exist cofnig editor on inbrowser.tld ux: unable to exist config editor on inbrowser.tld Jun 10, 2024
@SgtPooki
Copy link
Member

make clicking "Save config" collapse config when embedded on Iframe and remove /#/ipfs-sw-config from URL if not in iframe (on main domain)

this is supposed to already exist. Will look into this now.

@SgtPooki SgtPooki changed the title ux: unable to exist config editor on inbrowser.tld ux: unable to exit config editor on inbrowser.tld Jun 12, 2024
@SgtPooki
Copy link
Member

SgtPooki commented Jun 12, 2024

"save config" does close config edit screen on inbrowser.dev and local.

Actually, after clicking "reset config" it doesn't... interesting.

@SgtPooki
Copy link
Member

SgtPooki commented Jun 13, 2024

Actually, after clicking "reset config" it doesn't... interesting.

After clearing all storage in the browser, and having a valid config, the reload button works fine, I can't reproduce on inbrowser.dev when using the settings gear icon directly from the homepage, and clicking "save config" to close it.

clicking "reset config" and then "save config" also continues to work after I cleared browser settings

@SgtPooki
Copy link
Member

and now I can reproduce locally with the code from #293.... I need to figure out what is going on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants