Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support blake3 CIDs #260

Open
lidel opened this issue May 16, 2024 · 1 comment
Open

Support blake3 CIDs #260

lidel opened this issue May 16, 2024 · 1 comment
Labels
effort/hours Estimated to take one or several hours enhancement New feature or request exp/beginner Can be confidently tackled by newcomers good first issue Good for newcomers help wanted Extra attention is needed P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@lidel
Copy link
Member

lidel commented May 16, 2024

bafkr4ihkr4ld3m4gqkjf4reryxsy2s5tkbxprqkow6fin2iiyvreuzzab4 is blake3 and https://inbrowser.dev/ipfs/bafkr4ihkr4ld3m4gqkjf4reryxsy2s5tkbxprqkow6fin2iiyvreuzzab4 fails atm.

Spec-wise, we have blake3 listed as part of Web Pathing spec draft here, and to be production relady drop-in replacement for dweb.link, inbrowser.link should support the same hash functions (as brave/rainbow/kubo-based gateway).

@lidel lidel added this to the Prod: Initial release milestone May 16, 2024
@SgtPooki SgtPooki added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked labels Sep 18, 2024
@SgtPooki
Copy link
Member

SgtPooki commented Oct 3, 2024

The work required to do this is a little more involved than just adding a hasher:

  1. you would need to update the createVerifiedFetch call to pass a helia instance (a @helia/http instance for now) here:
    const verifiedFetch = await createVerifiedFetch({
    gateways: config.gateways,
    routers: config.routers,
    dnsResolvers
    }, {
    contentTypeParser
    })
  2. you need to instantiate a @helia/http instance, passing the gateway/routers config, adding the hashers configuration that includes blake3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours enhancement New feature or request exp/beginner Can be confidently tackled by newcomers good first issue Good for newcomers help wanted Extra attention is needed P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

2 participants