refactor: rename from go-ipfs to kubo #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
refactor/rename-npm-to-kubo
branch
from
0ea04ec
to
d440184
Compare
lidel
force-pushed
the
refactor/rename-npm-to-kubo
branch
from
d440184
to
da42209
Compare
galargh
approved these changes
Aug 18, 2023
|
Triggered manual build: https://github.com/ipfs/npm-kubo/actions/runs/5904170330/job/16015683148 |
|
Looks fine, but we had to swap Update: worked as expected, Kubo NPM v0.22 is live: https://www.npmjs.com/package/kubo |
lidel
commented
Aug 18, 2023
| @@ -33,7 +33,7 @@ const isWin = process.platform === 'win32' | |||
| * @param {string} url | |||
| */ | |||
| async function cachingFetchAndVerify (url) { | |||
| const cacheDir = process.env.NPM_GO_IPFS_CACHE || cachedir('npm-go-ipfs') | |||
| const cacheDir = process.env.NPM_GO_IPFS_CACHE || cachedir('npm-kubo') | |||
There was a problem hiding this comment.
ℹ️ missed env here, fixed in #65
achingbrain
reviewed
Sep 18, 2023
|
|
||
| [](https://ipfs.tech/) | ||
| [](https://github.com/RichardLitt/standard-readme) | ||
|
|
||
| > install [Kubo](https://github.com/ipfs/kubo) (previously known as "go-ipfs") from npm | ||
| > install [Kubo](https://github.com/ipfs/kubo) (previously known as "kubo") from npm |
There was a problem hiding this comment.
I don't think you meant to make this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
CC ipfs/kubo#8959