-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/commands: remove 'ipfs dht' commands, except 'query' #10328
Conversation
5d3411d
to
484e514
Compare
4435c7d
to
a5dbe86
Compare
This is blocked by progress in https://github.com/ipfs/js-kubo-rpc-client, which is extremely out of date. I extracted the Go RPC cleanup to #10329, which can be merged by itself. |
a5dbe86
to
dd29349
Compare
8e474db
to
2f62ff6
Compare
dd29349
to
e2fbffd
Compare
2f62ff6
to
3357e5f
Compare
e2fbffd
to
9fa8386
Compare
9365b3a
to
50caaf2
Compare
We agreed on doing a small patch in the JS client: ipfs/js-kubo-rpc-client#215 and release as a patch release, so people get this automatically. |
9fa8386
to
fcd4e71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that #10329 is doing the same thing we did in ipfs/js-kubo-rpc-client#215 and switch DHT to /routing backend, so lgtm.
FYI:
I've bumped js lib build a few times and it finally released:
That allowed us to restart CI job and helia-interop is green again:
Small cosmetics inline, but ok to merge (your call when @hacdias , since you also have #10329)
Thank you for cleaning this up, in the long term will reduce a lot of confusion.
fcd4e71
to
1dfd491
Compare
Co-authored-by: Marcin Rataj <[email protected]>
Built on #10329. This addresses some notes in #10265 (comment):
/api/v0/dht
commands, except for/api/v0/dht/query