Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2022-2274 #9097

Closed
3 tasks done
RubenKelevra opened this issue Jul 6, 2022 · 3 comments
Closed
3 tasks done

CVE-2022-2274 #9097

RubenKelevra opened this issue Jul 6, 2022 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@RubenKelevra
Copy link
Contributor

Checklist

Installation method

ipfs-update or dist.ipfs.io

Version

No response

Config

No response

Description

Correct me if I'm wrong, but older versions of kubo did create RSA keys and OpenSSL can be compiled as crypto library.

If kubo created 2048 bit rsa keys in the past, it's likely that CVE-2022-2274 (remote code execution, severity: high) does affect kubo as well.
ipfs
A possible mitigation would be to either forbid starting with OpenSSL library if there's a 2048 bit rsa key found or forbid to compile with OpenSSL if the version is vulnerable.

@RubenKelevra RubenKelevra added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Jul 6, 2022
@Jorropo
Copy link
Contributor

Jorropo commented Jul 6, 2022

@RubenKelevra no because no one worked on openssl in a while and so we do not support openssl v3 yet.
Thx for warning us but next time pls send an email to [email protected].

Someone sent a PR for openssl v3 here: libp2p/go-openssl#25 but I belive no one got the time to review it yet.

Also we dynamically link openssl, so even assuming we were susceptible you would only need to update openssl on your host, no changes required to Kubo.

PS: If you try go1.19 it now support borringssl (google's openssl fork) builtin which IMO is better than supporting a CGO lib ourself.

@Jorropo Jorropo closed this as completed Jul 6, 2022
@RubenKelevra
Copy link
Contributor Author

Well, it wasn't really related to IPFS itself and only an issue on custom builds, so I thought it's not a real security issue, just worth a heads-up :)

Thanks for the fast clarification, glad nobody is affected. :)

@Jorropo
Copy link
Contributor

Jorropo commented Jul 6, 2022

Well, it wasn't really related to IPFS itself and only an issue on custom builds, so I thought it's not a real security issue, just worth a heads-up

An RCE even on custom build deserve an email 🙂 if that would have been less important I guess it would have been fine.

glad nobody is affected

Because we are not update to date enough about that 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants