-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl: support openssl v3 #8882
Comments
Testing it on my machine (cross compiling) I have different errors. We don't have time to allocate to fix building openssl with termux. FYI I have managed to build inside termux without using openssl (and with quic support commented out because termux ships with go1.18.1 and my patience runned before trying to install go1.17). So for now, openssl isn't supported and you need to use go std's crypto lib. |
GOTAGS=openssl
on arm64/android
(could not determine kind of name for C.FIPS_mode_set)GOTAGS=openssl
on arm64/android
(could not determine kind of name for C.FIPS_mode_set)
I'm closing the issue so it wont show up bright green "help wanted" fyi, I don't want random people that want to help waste time on this (because we will probably not even review it). |
This issue might've invaded go version go1.18.1 linux/amd64
bin/check_go_version 1.17
plugin/loader/preload.sh > plugin/loader/preload.go
go fmt plugin/loader/preload.go >/dev/null
go install "-asmflags=all='-trimpath='" "-gcflags=all='-trimpath='" -ldflags="-X "github.com/ipfs/go-ipfs".CurrentCommit=126ebc459" -tags="openssl" ./cmd/ipfs
# github.com/libp2p/go-openssl
../../go/pkg/mod/github.com/libp2p/[email protected]/fips.go:31:7: could not determine kind of name for C.FIPS_mode_set
make: *** [cmd/ipfs/Rules.mk:37: cmd/ipfs-install] Error 2 |
@NatoBoram current
Also there hasn't been any change to our openssl wrapper since august 2021. Are you not running a rolling release by luck ? (what is your OS and version pls ?) |
I'm not running a rolling release, but I did upgrade to the latest Pop OS release recently This is what I'm running: OS: Pop!_OS 22.04 LTS x86_64
Kernel: 5.16.19-76051619-generic And I have this as my Package: openssl
Version: 3.0.2-0ubuntu1 |
I'm running |
GOTAGS=openssl
on arm64/android
(could not determine kind of name for C.FIPS_mode_set)
If anyone want to work on this, it's here: https://github.com/libp2p/go-openssl Should be easy, if you know a bit of C and Go. For now I'm leaving this for the community to fix, we will see with other maintainers but I don't think anyone of us is interested in that. |
Does libp2p/go-openssl#25 work for you? Unfortunately, I have no easy way to test this. |
Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days. |
This issue was closed because it is missing author input. |
upgrade go-openssl from v0.0.7 to v0.1.0
|
Could someone reopen this please? This issue is increasing in importance with every passing months, as more and more distros etc. switch to openssl 3. |
@h-vetinari we merged some code that should have fixed it, does that not work ? |
Turns out there was a "race condition" with the OpenSSL 3 PR & the release of v0.16; turns out things build fine with the newest version. Thanks a lot! :) |
Checklist
Installation method
built from source
Version
Config
No response
Description
When trying to build it from source with
GOTAGS=openssl
...I'm getting the following error.
Without
GOTAGS=openssl
, it works.On
linux/amd64
, it works.The text was updated successfully, but these errors were encountered: