Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: invalid car file loads infinitely #365

Open
SgtPooki opened this issue Jun 5, 2023 · 0 comments
Open

bug: invalid car file loads infinitely #365

SgtPooki opened this issue Jun 5, 2023 · 0 comments
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Jun 5, 2023

when I uploaded an empty file with .car extension there was just an in-progress animation forever; should there be a client side timeout?

We should:

  1. validate the car file & display error if not valid
  2. set timeout to error if loading valid car fails (match with bug: better resolution on fetch errors #363 solution)
@SgtPooki SgtPooki added need/triage Needs initial labeling and prioritization kind/bug A bug in existing code (including security flaws) good first issue Good issue for new contributors P2 Medium: Good to have, but can wait until someone steps up exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Jun 5, 2023
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Needs Grooming
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SgtPooki