Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os specific logic should be extracted into its own package #75

Open
whyrusleeping opened this issue Jan 2, 2018 · 2 comments
Open

os specific logic should be extracted into its own package #75

whyrusleeping opened this issue Jan 2, 2018 · 2 comments
Labels
help wanted Seeking public contribution on this issue

Comments

@whyrusleeping
Copy link
Member

Anything os specific (like HOME, and executable names) should get its own subpackage so we can keep that logic together and well tested

@hsanjuan hsanjuan added the help wanted Seeking public contribution on this issue label Jan 27, 2020
@godcong
Copy link
Contributor

godcong commented Sep 25, 2020

Does it mean something like these if runtime.GOOS == "windows" ?
Need to be changed to // +build windows flag?

@gammazero
Copy link
Contributor

Home directory expansion and home directory determination are now done using the github.com/mitchellh/go-homedir package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue
Projects
None yet
Development

No branches or pull requests

4 participants