Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Kubo Client Story and Deprecated Packages #1731

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Oct 9, 2023

Describe your changes

  1. Remove the bunch of packages that have been deprecated since we migrated to Boxo
  2. Point users to kubo/client/rpc - see more context in Point users at canonical kubo/client/rpc library kubo#9124.

Files changed

  • docs/reference/go/api.md
  • docs/reference/kubo-rpc-cli.md

Checklist before requesting a review

  • Passing the beta version of the Check Markdown links for modified files check. Action results can be viewed here.
    • Well, the action is complaining about a lot of links that were already there and I did not touch them.

Checklist before merging

  • Passing all required checks (The beta Check Markdown links for modified files check is not required)

@hacdias hacdias marked this pull request as draft October 9, 2023 08:57
@hacdias hacdias marked this pull request as ready for review October 9, 2023 08:58
@hacdias hacdias self-assigned this Oct 9, 2023
Comment on lines -51 to -52
> This table is generated using the module [`package-table`](https://github.com/ipfs-shipyard/package-table) with `package-table --data=package-list.json`.

Copy link
Member Author

@hacdias hacdias Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ I removed this because (1) this list is not generated by package-table anymore since 9459790 (package-table also does not have support for the Go Reference column), and (2) there's no package-list.json in this repository to generate it.

Copy link
Contributor

@ElPaisano ElPaisano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RE failing GH actions: We can ignore. Link check is flagging GH short link notation (i.e. link text like jeremy-ellis-tech/net-ipfs-http-client, ok) and spelling check is flagging part of a URL (codecov, ok).

@hacdias hacdias merged commit 6e971aa into main Oct 10, 2023
2 of 6 checks passed
@hacdias hacdias deleted the kubo-rpc-client branch October 10, 2023 10:12
@BigLep BigLep mentioned this pull request Nov 9, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants