Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deferred] Observe WebRequests and populate LFU Cache #1155

Open
1 of 3 tasks
whizzzkid opened this issue Feb 15, 2023 · 3 comments
Open
1 of 3 tasks

[deferred] Observe WebRequests and populate LFU Cache #1155

whizzzkid opened this issue Feb 15, 2023 · 3 comments
Assignees
Labels
area/chromium Issues related to Chromium-based browsers area/firefox Issues related to Mozilla Firefox area/MV3 Issues related to Manifest V3 version effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/architecture Core architecture of project P2 Medium: Good to have, but can wait until someone steps up status/deferred Conscious decision to pause or backlog status/ready Ready to be worked

Comments

@whizzzkid
Copy link
Contributor

whizzzkid commented Feb 15, 2023

Parent Issue: #1152

ETA: 2023-05-12

Tasks

Discussion Notes:

@whizzzkid whizzzkid added exp/expert Having worked on the specific codebase is important P0 Critical: Tackled by core team ASAP status/ready Ready to be worked area/firefox Issues related to Mozilla Firefox area/chromium Issues related to Chromium-based browsers kind/architecture Core architecture of project effort/days Estimated to take multiple days, but less than a week area/MV3 Issues related to Manifest V3 version labels Feb 15, 2023
@whizzzkid whizzzkid self-assigned this Mar 27, 2023
@BigLep
Copy link
Contributor

BigLep commented Jun 3, 2023

@whizzzkid : I'm wondering if we're over complicating this. A couple of thoughts:

  1. We can store 5k regexes right? Do we have a sense of whether 5k+ domains even have "IPFS support"? Related, over the course of someone's browsing session, how many unique domains (regardless if they have "IPFS support") does one have? My guess is that 5k is plenty big enough. Before we do work here, lets just get a metric on how big we find this to be in practice.
  2. Once the 5k limit is hit, what happens when you try to add another regex? Do you get an error? Do you have to choose what regex to evict so thee is space for the new regex you want to add?

@whizzzkid
Copy link
Contributor Author

@BigLep

Do we have a sense of whether 5k+ domains even have "IPFS support"? Related, over the course of someone's browsing session, how many unique domains (regardless if they have "IPFS support") does one have? My guess is that 5k is plenty big enough.

I agree, it does seem enough, however the second part answers this question.

Once the 5k limit is hit, what happens when you try to add another regex?

It's an error, this limit might change in the future if we're to believe chrome team. The cache would help us determine which rules are good to remove which needs to still be in there. In fact I was looking at 2Q cache implementation with a TTL, i.e. auto-purging all rules to free up space for more.

@BigLep
Copy link
Contributor

BigLep commented Jun 6, 2023

Ok, got it. It's good to know we get an error and thus have a metric we can report.

I don't think we should put energy on being fancy for now. I think we should ship and then can improve this later if we see the need in the metrics.

@whizzzkid whizzzkid added P2 Medium: Good to have, but can wait until someone steps up status/deferred Conscious decision to pause or backlog and removed P0 Critical: Tackled by core team ASAP labels Jun 12, 2023
@whizzzkid whizzzkid changed the title Observe WebRequests and populate LFU Cache [deferred] Observe WebRequests and populate LFU Cache Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chromium Issues related to Chromium-based browsers area/firefox Issues related to Mozilla Firefox area/MV3 Issues related to Manifest V3 version effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/architecture Core architecture of project P2 Medium: Good to have, but can wait until someone steps up status/deferred Conscious decision to pause or backlog status/ready Ready to be worked
Projects
No open projects
Status: Planned / Backlog
Development

No branches or pull requests

2 participants