Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recursive gateways (HTTPGatewayRouter) as a fallback when other routers fails #665

Open
2color opened this issue Oct 24, 2024 · 0 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@2color
Copy link
Member

2color commented Oct 24, 2024

Background

Right now the Routing class, which wraps the different router implementations (of which are 3) treats all routers as equal, and calls them in parallel (by using the merge from it-merge):

for await (const peer of merge(
queue.toGenerator(),
...supports(this.routers, 'findProviders')
.map(router => router.findProviders(key, options))

This means that if you have both:

  • delegatedHttpRouter (with delegated routing endpoint)
  • HTTPGatewayRouter (for recursive gasteways),

There is no programmatic way for your to prioritise direct retrieval over a recursive gateway.

Suggestion

In the following discussion, the idea of using
recursive gateways as a "last resort" fallback came up. This means that if direct retrieval fails (because there are no providers or because helia fails to retrieve directly from a provider), it falls back on the recursive gateway to fetch data.

@2color 2color added the kind/enhancement A net-new feature or improvement to an existing feature label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant