chore: remove ipfs-unixfs-importer from bundle #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2color
approved these changes
Mar 27, 2024
|
Note to self: This is affecting the |
|
I've opened #42 as an alternative here. Instead of removing deps from the tree (which may have unpredictable results), we could just remove |
|
we should follow the approach from #42 |
This was referenced Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
chore: remove ipfs-unixfs-importer from bundle
Description
fixes #31
Notes & open questions
removes ipfs-unixfs-importer from the bundle
This is potentially dangerous because we're explicitly removing it from the resulting bundle and ipfs-unixfs-importer may export some things that are needed by @helia/unixfs for non-importing cases.
However, tests seem to pass locally with this change.
Change checklist