Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http tests fail with recent versions of github.com/rs/cors #100

Open
keks opened this issue Apr 20, 2018 · 1 comment
Open

http tests fail with recent versions of github.com/rs/cors #100

keks opened this issue Apr 20, 2018 · 1 comment

Comments

@keks
Copy link
Contributor

keks commented Apr 20, 2018

Namely, when using rs/cors@8dd4211 or later.
@keks
Copy link
Contributor Author

keks commented Apr 23, 2018

@lgierth I think you know most about what HTTP headers to expect.

When configured to accept all origins, old versions of rs/cors send an AllowOrigin: <sent Origin> header. New versions will send AllowOrigin: *. Should I change the tests to accept both the supplied Origin and * when configured to accept all origins, or do we need to fix something in the code? CORS, like most web "technology", is still bat country to me... 🦇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keks