Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

shell.Add always wraps a folder even only one file is added #277

Closed
CsterKuroi opened this issue Nov 2, 2022 · 4 comments
Closed

shell.Add always wraps a folder even only one file is added #277

CsterKuroi opened this issue Nov 2, 2022 · 4 comments
Labels
P2 Medium: Good to have, but can wait until someone steps up status/blocked Unable to be worked further until needs are met

Comments

@CsterKuroi
Copy link

This is a big overhead for systems that often add a single file when use go-ipfs-api.

@CsterKuroi CsterKuroi added the need/triage Needs initial labeling and prioritization label Nov 2, 2022
@welcome
Copy link

welcome bot commented Nov 2, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@CsterKuroi
Copy link
Author

func (s *Shell) Add(r io.Reader, options ...AddOpts) (string, error) {

@guseggert
Copy link
Contributor

This should be addressed as part of ipfs/kubo#9124

@guseggert guseggert added P1 High: Likely tackled by core team if no one steps up status/blocked Unable to be worked further until needs are met and removed need/triage Needs initial labeling and prioritization labels Nov 10, 2022
@guseggert guseggert added P2 Medium: Good to have, but can wait until someone steps up and removed P1 High: Likely tackled by core team if no one steps up labels Feb 20, 2023
@lidel
Copy link
Member

lidel commented Feb 27, 2023

We will not spend time on improving this library, let's continue in ipfs/kubo#9124

@lidel lidel closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Medium: Good to have, but can wait until someone steps up status/blocked Unable to be worked further until needs are met
Projects
None yet
Development

No branches or pull requests

3 participants