Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

need to support a Filestore nocopy option #275

Open
ec1oud opened this issue Oct 17, 2022 · 2 comments
Open

need to support a Filestore nocopy option #275

ec1oud opened this issue Oct 17, 2022 · 2 comments
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now

Comments

@ec1oud
Copy link

ec1oud commented Oct 17, 2022

Kubo has FilestoreEnabled as an experimental option. I think not duplicating data (and not storing it in an obfuscated way, when I've already got the files that I want to share, and intend to keep them in the same place) is an obvious good idea: IMO it should no longer be experimental unless there are too many things that can go wrong. https://github.com/ipfs/kubo/blob/master/docs/experimental-features.md#ipfs-filestore says "Needs more people to use and report on how well it works"; but having API support for this would be a good way to get more people to use it.

@ec1oud ec1oud added the need/triage Needs initial labeling and prioritization label Oct 17, 2022
@welcome
Copy link

welcome bot commented Oct 17, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@Jorropo
Copy link

Jorropo commented Nov 17, 2022

Filestore has corruptions issue if you modify / remove / move files that are still stored in filestore, it's probably not gonna get unexperimentalled at any time in favor of reflinking (same trick but done by the kernel with Copy-On-Write so no corruption possible).

We have two Kubo go api clients for history reasons, the other one have it afaik.
https://github.com/ipfs/go-ipfs-http-client

If you want to add it to this package I'll be happy to review it.

@Jorropo Jorropo added kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now help wanted Seeking public contribution on this issue and removed need/triage Needs initial labeling and prioritization labels Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

2 participants