You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This test reads a file with an entity-bytes param from the -99999 index (i.e. beginning of the file) up to the -3 index (i.e. everything but the last two bytes).
What
This test reads a file with an entity-bytes param from the -99999 index (i.e. beginning of the file) up to the -3 index (i.e. everything but the last two bytes).
The expectations as written appear to be testing that all but the last block of the generated car file are returned:
https://github.com/ipfs/gateway-conformance/blob/main/tests/trustless_gateway_car_test.go#L637
However, if one looks at the underlying file, https://github.com/ipfs/gateway-conformance/blob/main/fixtures/trustless_gateway_car/subdir-with-mixed-block-files.car, via CAR inspection, one funds the underlying file is 4098 bytes long, with each block 1024 bytes, for 4 1024 blocks and 1 2 byte block to complete the file. So it has a total of 5 blocks.
Meaning that https://github.com/ipfs/gateway-conformance/blob/main/tests/trustless_gateway_car_test.go#L637 as written is actually expecting the whole file to be read, which is incorrect behavior.
The reason it passes for boxo is due to a seperate bug -- ipfs/boxo#523
The text was updated successfully, but these errors were encountered: