Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist.sh should check that the new version is newer than the current version #319

Open
olizilla opened this issue Oct 23, 2020 · 0 comments · May be fixed by #376
Open

dist.sh should check that the new version is newer than the current version #319

olizilla opened this issue Oct 23, 2020 · 0 comments · May be fixed by #376
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Milestone
Best Effort Track

Comments

@olizilla
Copy link
Member

A note-to-self to make dist.sh verify that the new-version is in fact newer in semver terms than the current version... we avoid setting release candidates as current, but we dont guard against setting older versions as current. Minor but feels like a foot gun.

distributions/dist.sh

Lines 58 to 63 in 211588d

case "$nvers" in
*-*) echo "WARNING: not marking pre-release $dist $nvers as the current version." ;;
*) echo "$nvers" > "dists/$dist/current" ;;
esac
echo "$nvers" >> "dists/$dist/versions"

@olizilla olizilla added the need/triage Needs initial labeling and prioritization label Oct 23, 2020
@jessicaschilling jessicaschilling added dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked labels Oct 23, 2020
@lidel lidel removed the need/triage Needs initial labeling and prioritization label Jun 18, 2021
AlexxNica added a commit to AlexxNica/distributions that referenced this issue Jul 30, 2021
@AlexxNica
fix(release): assure new release version is greater than the current …
1f7fd54 
…one.

Fixes ipfs#319
@AlexxNica AlexxNica linked a pull request Jul 30, 2021 that will close this issue
Draft
3 tasks
@BigLep BigLep added this to the Best Effort Track milestone Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
No open projects
IPFS Shipyard Team
Status: 🔎 In Review
Milestone
Best Effort Track
Development

Successfully merging a pull request may close this issue.

fix(release): assure new release version is greater than the current one AlexxNica/distributions
4 participants
@olizilla @BigLep @lidel @jessicaschilling