-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ensure sharness fails on breaking changes #138
Conversation
Codecov Report
@@ Coverage Diff @@
## migrate-gateway #138 +/- ##
================================================
Coverage 17.95% 17.95%
================================================
Files 94 94
Lines 10368 10368
================================================
Hits 1862 1862
Misses 8245 8245
Partials 261 261
|
Note: Sharness tests should be failing unless we revert 3073d33. But they aren't. Trying to fix. It seems that the go mod replace is not being properly applied and we're not using the correct version. |
Run https://github.com/ipfs/go-libipfs/actions/runs/4045150857/jobs/6956236711 shows that the CI is working properly and sharness tests fail if breaking changes are introduced to the gateway. For this I used the branch of ipfs/kubo#9588. Now, I will revert this to use the main branch and once ipfs/kubo#9588 is merged, we will have a proper CI setup running. |
This reverts commit 48e125b.
No description provided.