Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure sharness fails on breaking changes #138

Merged
merged 9 commits into from
Jan 30, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jan 30, 2023

No description provided.

@hacdias hacdias changed the base branch from main to migrate-gateway January 30, 2023 13:36
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #138 (a16ad88) into migrate-gateway (a059026) will not change coverage.
The diff coverage is 0.00%.

❗ Current head a16ad88 differs from pull request most recent head 9e01b60. Consider uploading reports for the commit 9e01b60 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           migrate-gateway     #138   +/-   ##
================================================
  Coverage            17.95%   17.95%           
================================================
  Files                   94       94           
  Lines                10368    10368           
================================================
  Hits                  1862     1862           
  Misses                8245     8245           
  Partials               261      261           
Impacted Files Coverage Δ
gateway/handler_tar.go 0.00% <0.00%> (ø)

@hacdias hacdias changed the title Test PR for CI checker chore: ensure sharness fails on breaking changes Jan 30, 2023
@hacdias
Copy link
Member Author

hacdias commented Jan 30, 2023

Note: Sharness tests should be failing unless we revert 3073d33. But they aren't. Trying to fix. It seems that the go mod replace is not being properly applied and we're not using the correct version.

@hacdias
Copy link
Member Author

hacdias commented Jan 30, 2023

Run https://github.com/ipfs/go-libipfs/actions/runs/4045150857/jobs/6956236711 shows that the CI is working properly and sharness tests fail if breaking changes are introduced to the gateway. For this I used the branch of ipfs/kubo#9588. Now, I will revert this to use the main branch and once ipfs/kubo#9588 is merged, we will have a proper CI setup running.

@hacdias hacdias marked this pull request as ready for review January 30, 2023 15:15
@hacdias hacdias merged commit 2739084 into migrate-gateway Jan 30, 2023
@hacdias hacdias deleted the gateway-ttt branch January 30, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant