Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin: cleanup pin indexes and storage #538

Open
hacdias opened this issue Jan 8, 2024 · 0 comments
Open

pin: cleanup pin indexes and storage #538

hacdias opened this issue Jan 8, 2024 · 0 comments
Labels
dif/hard Having worked on the specific codebase is important effort/days Estimated to take multiple days, but less than a week P3 Low: Not priority right now

Comments

@hacdias
Copy link
Member

hacdias commented Jan 8, 2024

Currently, the pinning/pinner package is built in such a way that the internals would technically allow for multiple pins of the same CID, while in practice that is not possible. In addition, it makes maintenance tasks or new features, such as #537, more complicated.

The idea here would be to simplify the current indexes to only having one value per key. In addition, when updates are made, avoid deleting and writing a new pin again to a different key in the datastore. Instead, reuse the same key and simply override the the information. Perhaps the ID could even be based on the CID (currently it is random).

@hacdias hacdias added the need/triage Needs initial labeling and prioritization label Jan 8, 2024
@hacdias hacdias added P3 Low: Not priority right now dif/hard Having worked on the specific codebase is important effort/days Estimated to take multiple days, but less than a week and removed need/triage Needs initial labeling and prioritization labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dif/hard Having worked on the specific codebase is important effort/days Estimated to take multiple days, but less than a week P3 Low: Not priority right now
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant