Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with enabling WebRTC in js-ipfs fallback #58

Closed
lidel opened this issue Nov 27, 2018 · 2 comments · Fixed by #121
Closed

Experiment with enabling WebRTC in js-ipfs fallback #58

lidel opened this issue Nov 27, 2018 · 2 comments · Fixed by #121
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@lidel
Copy link
Member

lidel commented Nov 27, 2018

What if we enable WebRTC in fallback js-ipfs node?

In the past browsers had stability issues when js-ipfs run with webrtc transport for a long time.
We had various changes since then across the stack and the tab with share app will usually be closed after user is done with upload/download minimizing risk of it running for long enough to cause trouble.

Could WebRTC potentially..

  • improve discovery and performance of sharing app
  • give more merit to p2p claims made in copy/docs :)
  • build better understanding of how stable WebRTC transport is today, identify pain points and work towards addressing them in ipfs/libp2p/browser stack.

?

Refs:

@lidel lidel added the kind/enhancement A net-new feature or improvement to an existing feature label Nov 27, 2018
@lidel lidel changed the title Enable WebRTC in js-ipfs fallback Experiment with enabling WebRTC in js-ipfs fallback Nov 27, 2018
@olizilla
Copy link
Member

I'm for this, but not yet. I think we need to make "understanding WebRTC limits and tuning" a high priority. I'd rather have us dedicate focused time to understandting the root causes of the problem and the effects of the tuning options before enabling it again on an app.

@lidel
Copy link
Member Author

lidel commented Feb 4, 2021

iiuc we switched to the latest js-ipfs where webrtc is enabled by default supported

Update: turns out explicit signaling addr needs to be passed + we need to tweak transport manager's fault tolerance to be NO_FATAL, so js-ipfs still works even if all signaling servers are down (we still have wss to bootstrappers/preloads)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants