-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infer variable name improvements #72
Conversation
I thing I'm going to revert last commit as there is no need to display not clean variant. |
Wow, that's super cool! I love the idea! |
Head branch was pushed to by a user without write access
Though I still didn't figure out how to fix |
From my POV these cases are pretty common and we should support them: for (let command of MenuRegistry.getCommands()) {
} Shouldn't be hard since we have both extraction functions in place, try to do this soon or you can handle them |
Correct, that's a very common case. I'm on my phone now but i already know it's another 2 lines of code so i will implement that if i have 15 minutes this weekend 😉 |
Also what do you think of this pattern? Do you think its common and we can handle it? for (let indexToPatch of indexesToPatch) {
} index -> indexes |
fix for singular of 'cookies' is not 'cooky' plurals/pluralize#192 (comment)
enable proposal of multiple variants
something.messages.forof