-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggest adding more details to building new notebooks in contributing guide #193
Comments
Maybe https://docs.jupyter.org/en/latest/start/index.html ?
This is a broad question and the answer may vary from case-to-case. Here is a few things I can think of: Scenario 1 Answer: Do the slicing offline and provide that step as an example. Scenario 2 Answer: We will skip that notebook from the CIs run but, if the notebook runs on someone's machine, we can publish it with a caveat that it will take some time/resources to run it locally. Scenario 3 Answer: As long as the CI run time can handle the request, we can publish as-is, if not, use solution 2. Scenario 4 Answer: We can add it as an artifact on GH releases and fetch the data from it.
Not sure what scenarios you are thinking here but, as long as someone can run the notebook, this can fall into the same large data scenario 2, where we can publish it but we won't run on our CIs.
This is a tough one and probably the most important one IMO. Jupyter has a Narrative Section on their docs that could help but it is just a placeholder at the moment. |
That was my initial thought. But that really introduces the concept of a jupyter notebook. It doesn't describe what the content should be. |
Yeah. Which leads us to the "Narrative" part that is incomplete. I guess we should write our own. |
Bullet 4 in https://github.com/ioos/ioos_code_lab/blob/main/CONTRIBUTING.md#building-new-notebooks should include:
The text was updated successfully, but these errors were encountered: