Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionide-vim will no longer install FSAC on its own #51

Open
cannorin opened this issue Feb 6, 2022 · 2 comments
Open

Ionide-vim will no longer install FSAC on its own #51

cannorin opened this issue Feb 6, 2022 · 2 comments
Assignees

Comments

@cannorin
Copy link
Member

cannorin commented Feb 6, 2022

Related: ionide/FsAutoComplete#883
FsAutoComplete now encourage users to manage FSAC via dotnet tool: dotnet tool install fsautocomplete for project-local install and dotnet tool install -g fsautocomplete for global install.
Ionide-vim used to manage FSAC on its own, but following the above change, it will no longer do so and will require users to install FSAC via dotnet tool install.

  • The command :FSharpUpdateFSAC will be removed.
  • The default value of g:fsharp#fsautocomplete_command will be ['fsautocomplete', '--background-service-enabled'] (globally-installed FSAC).
  • Ionide-vim will no longer require running make fsautocomplete on installation.
@tnishimura
Copy link

Instead of getting rid of installation entirely, maybe do dotnet install -g fsautocomplete in the Makefile instead? Might be less surprising for people not paying attention to these issues. Just a suggestion...

One potential problem is that running global tools requires the user has ~/.dotnet/tools in $PATH (or equivalent on windows) properly.

@zetashift
Copy link

Instead of getting rid of installation entirely, maybe do dotnet install -g fsautocomplete in the Makefile instead? Might be less surprising for people not paying attention to these issues. Just a suggestion...

One potential problem is that running global tools requires the user has ~/.dotnet/tools in $PATH (or equivalent on windows) properly.

Could be done, but I'd still recommend not auto-running the makefile then, imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants