Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature data pops us when within a string literal #1791

Open
alfonsogarciacaro opened this issue Oct 9, 2022 · 1 comment · May be fixed by ionide/FsAutoComplete#1022
Open

Signature data pops us when within a string literal #1791

alfonsogarciacaro opened this issue Oct 9, 2022 · 1 comment · May be fixed by ionide/FsAutoComplete#1022

Comments

@alfonsogarciacaro
Copy link
Contributor

Somehow related to #1575

When writing the contents of a string in an argument position, the signature data of the function is always popping up which is a bit distracting, particularly when using the "Highlight templates in F#" extension (see screen capture below).

The fix for #1575 was done in FsAutocomplete but I think in the case the code generating the signature data is here. Is there an easy way to detect if we're within a string literal and deactivate the popup in that case? (I had here some hacky code using regex for that.)

screencast
@alfonsogarciacaro alfonsogarciacaro linked a pull request Oct 9, 2022 that will close this issue
Open
@alfonsogarciacaro
Copy link
Contributor Author

Sorry, I made a mistake by confusing "Signature Help" with "Signature Data". It looks like this also needs to be fixed in FsAutocomplete. I tried to send a PR for that here: ionide/FsAutoComplete#1022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check completion context for signature help alfonsogarciacaro/FsAutoComplete
1 participant
@alfonsogarciacaro