Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve path of injectedGlobals relative to config file #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jase88
Copy link

@jase88 jase88 commented Feb 7, 2021

resolve path of injectedGlobals relative to config file (fallback to rootDir if optional configPath is not set)

fixes #49

@kevinmcgillicuddy
Copy link

cloned this PR and linked to my project and could not get it work, what did work for me was having getRenderOptions return in format @use 'file:///c:/.....'

Other wise the function was returning a path with a drive letter which Unix has no concept of and it was unable to find the stylesheet

referenced here:
sass/dart-sass#669

@jase88
Copy link
Author

jase88 commented Mar 6, 2021

Okay sounds like you had a different issue than me or did I break things working on master?

In general the error message that is thrown on dart-sass is not helpful, because it doesn't reveal the failing path of the import (that is here dynamically added).

@jase88
Copy link
Author

jase88 commented Mar 17, 2021

Hey @adamdbradley, can you or someone else have a look for this PR?

Thanks in advance

@pmachaux
Copy link

Hi,
Any news on when this issue will be fixed? I am facing the exact same issue
Thanks

@splitinfinities
Copy link
Contributor

Hey there, thank you for the patience getting back to you. The new team is getting started and we're working through the backlog now.

I'm going to take a peek at this and cut a prerelease here soon. I'd love feedback on it once it's ready. I'll circle back shortly.

@rallz-dev
Copy link

any news on this? I'm trying to use Nx to manage my monorepo but with this problem, it is not feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with "Can't find stylesheet to import." if injectGlobalPaths is used
7 participants