Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update angular starter set config #1822

Closed
wants to merge 0 commits into from

Conversation

luisbytes
Copy link
Contributor

Update of the base angular starter templates, based on the default project generated with ng new.

In the angular stantalone starter base the builder browser was changed by application, this last one is the default builder in the new Angular v17 projects.

This is the Angular docs about the application builder

@luisbytes luisbytes requested a review from a team as a code owner November 14, 2023 19:50
@luisbytes luisbytes requested review from sean-perkins and removed request for a team November 14, 2023 19:50
@luisbytes luisbytes changed the title chore: update angular starter config to v17 chore: update angular starter set config Nov 14, 2023
@luisbytes
Copy link
Contributor Author

Hello @sean-perkins, could you please take a look?

"main": "src/main.ts",
"polyfills": "src/polyfills.ts",
"browser": "src/main.ts",
"polyfills": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These polyfill changes will no longer require the zone-flags.ts polyfill that we include for custom elements. I don't think we have enough data points to remove them at this stage.

With zoneless Angular coming "soon", I'd personally recommend we leave it alone until that comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants