chore: updates angular starters to v17 #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
requested review from
liamdebeasi
and removed request for
a team
sean-perkins
force-pushed
the
sp/angular-17
branch
from
3450a02 to
75699e6
Compare
sean-perkins
commented
Nov 10, 2023
| @@ -4,7 +4,7 @@ | |||
| <ion-content> | |||
| <ion-list id="inbox-list"> | |||
| <ion-list-header>Inbox</ion-list-header> | |||
| <ion-note>[email protected]</ion-note> | |||
There was a problem hiding this comment.
After upgrading the lint package, using the @ resulted in an error:
Error: src/app/app.component.html:7:23 - error NG5002: Incomplete block "ionicframework". If you meant to write the @ character, you should use the "@" HTML entity instead.
| "@ionic/angular-toolkit": "^9.0.0", | ||
| "@types/jasmine": "~4.3.0", | ||
| "@types/node": "^12.11.1", | ||
| "@typescript-eslint/eslint-plugin": "5.3.0", |
There was a problem hiding this comment.
Upgraded the lint plugin to v6 as a result of this error:
/Users/sean/Documents/ionic/starters/build/angular-official-sidemenu/src/app/app-routing.module.ts
0:0 error Parsing error: DeprecationError: 'originalKeywordKind' has been deprecated since v5.0.0 and can no longer be used. Use 'identifierToKeywordKind(identifier)' instead
liamdebeasi
reviewed
Nov 13, 2023
liamdebeasi
reviewed
Nov 13, 2023
|
@liamdebeasi which starter template are you testing against? |
|
|
|
Do you have a globally installed version of Angular CLI? If so is the version less than v17? If so, can you try updating it: I'm unable to reproduce locally with Angular CLI v17.0.0, unless you are seeing it for something other than start/build:
|
liamdebeasi
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the modules and starter base angular projects to default to Angular 17.
Notes for reviewers:
@types/nodedev-dependency. It was introduced in supporting Angular 11, but is definitely not a required dev dependency for Angular and isn't a part of the project defaults when generating a project withng new. As such, I've removed it.