feat(angular): use Ionic standalone components #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetaPC
requested review from
a team,
brandyscarney and
mapsandapps
and removed request for
a team and
brandyscarney
mapsandapps
suggested changes
Sep 15, 2023
There was a problem hiding this comment.
I saw a couple things in here that differed from the guide.
As well as the other comments, it looks like
{
"glob": "**/*.svg",
"input": "node_modules/ionicons/dist/ionicons/svg",
"output": "./svg"
}
needs to be removed from the angular.json (twice in the same file).
| import { DataService, Message } from '../services/data.service'; | ||
|
|
||
| addIcons({ personCircle }); |
There was a problem hiding this comment.
The docs (step 7) use addIcons in the constructor. Is there a reason it's better in one place over the other? (I'm least-familiar with Angular, and I don't know the answer.)
There was a problem hiding this comment.
I'm not sure, I was following the design doc. I'll switch to follow the Framework docs to stick with consistency.
angular-standalone/official/list/src/app/message/message.component.ts
Outdated
Show resolved
Hide resolved
|
@mapsandapps I updated the versions and would like a double check that everything still works. |
sean-perkins
approved these changes
Oct 12, 2023
mapsandapps
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
Angular standalone starter doesn't use the Ionic standalone components.
What is the new behavior?
Angular standalone starter uses the Ionic standalone components.
Does this introduce a breaking change?
Other information
Leaving it as a draft to prevent the PR to be merged until the mentioned criteria above are met.
Verify that all the Angular standalone starters: