Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/new theme #249

Merged
merged 9 commits into from
Dec 8, 2023
Merged

Chore/new theme #249

merged 9 commits into from
Dec 8, 2023

Conversation

jaredcbaum
Copy link
Contributor

@jaredcbaum jaredcbaum commented Nov 13, 2023 •
edited
Loading

This PR:

  • removes @ionic-internal/preset-classic package in favor of @ionic-docs/preset-classic
  • refactors docusaurus.config.js to work with new preset
  • refactors package.json to remove packages abstracted to preset
  • removes unnecessary local styles
  • formats docusaurus.config.js with ionic prettier formatting rules

@Steven0351
Copy link
Member

The new preset looks great!

@jthoms1
Copy link
Contributor

jthoms1 commented Dec 8, 2023

We good to ship? Looks good to me.

@jaredcbaum jaredcbaum merged commit 3cfbc30 into main Dec 8, 2023
1 check passed
@jaredcbaum jaredcbaum deleted the chore/new-theme branch December 8, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steven0351 Steven0351 Steven0351 approved these changes

@jthoms1 jthoms1 jthoms1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredcbaum @Steven0351 @jthoms1