Output to non-console handles?

[ysc3839]

In lxlaunch.cpp:203 it checks whether the output handle is a console handle. I wonder if it's possible to make it supports non-console handles?

[joshouamel]

발견했습니다..
영어로 뭐라 해야되나..
i solved (??)

if (GetFileType(inHandle) != FILE_TYPE_CHAR)
{
stdHandles.StdIn.Handle = (ULONG)inHandle;
stdHandles.StdIn.Pipe = true;
}else{
oldInCp = GetConsoleCP();
SetConsoleCP(CP_UTF8);
GetConsoleMode(inHandle, &oldInMode);
SetConsoleMode(inHandle, oldInMode &
~(ENABLE_INSERT_MODE |
ENABLE_ECHO_INPUT |
ENABLE_LINE_INPUT |
ENABLE_PROCESSED_INPUT) |
(ENABLE_VIRTUAL_TERMINAL_INPUT |
ENABLE_WINDOW_INPUT));
}

[ysc3839]

Doesn't work...

[joshouamel]

유감

[joshouamel]

I guess this is caused by two lxss processes running in a console window.
The redirection to non-lxss works well.

I do not know what 2 means, but it will be good for you.

hr = ((PLX_INSTANCE_V2)iLxInstance)->CreateLxProcess(
(PLX_INSTANCE_V2)iLxInstance,
imageFileName,
cmdCount,
cmdLine,
"C:\windows\system32;c:\windows",
currentDirectory,
2,
// LX_CREATE_PROCESS_PRINT_UPDATE_INFO_FLAG,
&stdHandles,
&consoleData2,
0,
&processHandle,
&serverHandle);
}

[ysc3839]

I think it's because lxss requires a console to output. In RS2 it handles console input and output, so there's no way to output to non-console handles.

[ionescu007]

There is, if you pass it marshaled pipe handles to what you're trying to "pipe" to. Once RS2 is finalized, I may add support for this. Best regards, Alex Ionescu

…

On Sun, Jan 15, 2017 at 4:10 AM, Richard Yu ***@***.***> wrote: I think it's because lxss requires a console to output. In RS2 it handles console input and output, so there's no way to output to non-console handles. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFxIeGNLO0HZ6HynoIJxxzvOIhxtS11Qks5rSZwlgaJpZM4K9ftI> .

[ysc3839]

What do you mean? 🤔

[ionescu007]

Instead of passing console handles, you can pass stdin/out handles. I will add support once Redstone 2 ships. Best regards, Alex Ionescu

…

On Sun, Jan 15, 2017 at 10:19 AM, Richard Yu ***@***.***> wrote: What do you mean? 🤔 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFxIeNnmO8YLweh7pFRWKnglfLzRUGTIks5rSfK3gaJpZM4K9ftI> .

[joshouamel]

I have confirmed that it works well, but I am sorry that I can not show it.
So I'll show you the code.

//...skip
ULONG Flag = LX_CREATE_PROCESS_PRINT_UPDATE_INFO_FLAG;
//
// Get, and validate, the output handle
//
outHandle = GetStdHandle(STD_OUTPUT_HANDLE);
if (GetFileType(outHandle) != FILE_TYPE_CHAR)
{
stdHandles.StdOut.Pipe = true;
stdHandles.StdOut.Handle = HandleToULong(outHandle);
Flag = 2;
}
else {
//
// Switch to VT-100 Output Console
//
GetConsoleMode(outHandle, &oldOutMode);
SetConsoleMode(outHandle, oldOutMode |
DISABLE_NEWLINE_AUTO_RETURN |
0x4 |
ENABLE_PROCESSED_OUTPUT);
//
// Switch output to UTF-8
//
oldOutCp = GetConsoleOutputCP();
SetConsoleOutputCP(CP_UTF8);
}

//
// Get, and validate, the output handle
//
inHandle = GetStdHandle(STD_INPUT_HANDLE);
if (GetFileType(inHandle) != FILE_TYPE_CHAR)
{
	stdHandles.StdIn.Handle = HandleToULong(inHandle);
	stdHandles.StdIn.Pipe = true;
}
else {
	//
	// Switch to VT-100 Input Console
	//
	GetConsoleMode(inHandle, &oldInMode);
	SetConsoleMode(inHandle, oldInMode &
		~(ENABLE_INSERT_MODE |
			ENABLE_ECHO_INPUT |
			ENABLE_LINE_INPUT |
			ENABLE_PROCESSED_INPUT) |
		(ENABLE_VIRTUAL_TERMINAL_INPUT |
			ENABLE_WINDOW_INPUT));


	//
	// Switch input to UTF-8
	//
	oldInCp = GetConsoleCP();
	SetConsoleCP(CP_UTF8);

}

//...skip
hr = ((PLX_INSTANCE_V2)iLxInstance)->CreateLxProcess(
(PLX_INSTANCE_V2)iLxInstance,
imageFileName,
cmdCount,
cmdLine,
"C:\windows\system32;c:\windows",
currentDirectory,
Flag,
&stdHandles,
&consoleData2,
0,
&processHandle,
&serverHandle);

//...skip

[ysc3839]

@ionescu007 So you mean RS2 supports non-console handles? What about RS1?

[ionescu007]

RS1 does as well I believe, with the code that joshuamel has written, which looks mostly correct. Best regards, Alex Ionescu

…

On Sun, Jan 15, 2017 at 12:54 PM, Richard Yu ***@***.***> wrote: @ionescu007 <https://github.com/ionescu007> So you mean RS2 supports non-console handles? What about RS1? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFxIeMqnEtvpee7SUy7u7ZeVQiMYUJMCks5rShcUgaJpZM4K9ftI> .

[ysc3839]

@joshouamel Tested on 10.0.14393, still doesn't work...
My code: https://gist.github.com/ysc3839/078f3137ce5b5e8b3104ba5cbaa88d7b

[joshouamel]

Of course it will not work out. What about Anonymous pipes rather than named pipes? Two programs could not share a pipe. You do not have to wait if inhandle is in pipe mode at the end of the process.

waitArray[0] = UlongToHandle(processHandle);
waitArray[1] = GetStdHandle(STD_INPUT_HANDLE);
if(stdHandles.StdIn.Pipe)
WaitForSingleObject(waitArray[0], INFINITE);
else while (WaitForMultipleObjects(RTL_NUMBER_OF(waitArray),
waitArray,
FALSE,
INFINITE))
{
//
// Read the console input -- we only care about key pressses
//
assert(useRs2Logic == FALSE);
ReadConsoleInput(waitArray[1], &record, 1, &eventsRead);
if ((record.EventType == KEY_EVENT) &&
(record.Event.KeyEvent.bKeyDown != FALSE))
{
//
// Write into the Linux input pipe the character
//
WriteFile(inPipe,
&record.Event.KeyEvent.uChar.AsciiChar,
1,
&bytesWritten,
NULL);
}
}