You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we have multiple functions for cleaning spectra.
Proposed change: Make a class CleanSpectra
The class should take spectra in as input. Instead of passing spectrum_list from function to function. This object should be stored.
The methods involved in cleaning spectra should be stored.
The class should keep track of all the cleaning steps applied to the original spectra set. This makes it possible to keep track of all the steps performed, reduces risks of wrong steps and should store all the settings used for the filtering and the order.
Currently we have separate functions for cleaning query spectra and library spectra, it would be good to combine this.
Might be a good to add a CleanSpectra class to matchms directly as well.
The text was updated successfully, but these errors were encountered:
Currently we have multiple functions for cleaning spectra.
Proposed change: Make a class CleanSpectra
The class should take spectra in as input. Instead of passing spectrum_list from function to function. This object should be stored.
The methods involved in cleaning spectra should be stored.
The class should keep track of all the cleaning steps applied to the original spectra set. This makes it possible to keep track of all the steps performed, reduces risks of wrong steps and should store all the settings used for the filtering and the order.
Currently we have separate functions for cleaning query spectra and library spectra, it would be good to combine this.
Might be a good to add a CleanSpectra class to matchms directly as well.
The text was updated successfully, but these errors were encountered: