Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Shelly 2PM Gen 3 #1057

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Conversation

rockflopp
Copy link
Contributor

Hi there, this is my first pull request and all changes were made with the help of GenAI. I had bought new Gen3 Devices which weren't supported yet so I added them to the Adapter and tested it on my smarthomesetup where it worked fine. Please Check with care as this is my first pull request ever.

Thanks

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
lib/devices/gen3/shelly2pmg3.js Outdated Show resolved Hide resolved
lib/datapoints.js Show resolved Hide resolved
@rockflopp
Copy link
Contributor Author

I think I fixed all your change request.

@klein0r klein0r merged commit 1fe7d86 into iobroker-community-adapters:master Oct 8, 2024
1 check passed
@klein0r
Copy link
Contributor

klein0r commented Oct 8, 2024

Thank you!

@crunchip77
Copy link

crunchip77 commented Oct 11, 2024

@klein0r weil es um v8.3 Integration des 2pm gen3 geht, frag ich hier direkt mal nach, hoffe das ist ok
beim Upgrade ist mir folgendes aufgefallen, bzw kein Plan ob man diesem Beachtung schenken muss.
buanet docker auf Unraid
siehe
`$ iobroker upgrade [email protected] --debug

Update shelly from @8.2.1 to @8.3.0

NPM version: 10.8.2

Installing [email protected]... (System call)

[email protected] install> node-gyp rebuild

gyp info it worked if it ends with ok

gyp info using [email protected] info using [email protected] | linux | x64

gyp info find Python using Python version 3.11.2 found at "/usr/bin/python3"

gyp ERR! UNCAUGHT EXCEPTION gyp ERR! stack TypeError: Cannot assign to read only property 'cflags' of object '#'gyp ERR! stack at createConfigFile (/opt/iobroker/node_modules/usocket/node_modules/node-gyp/lib/configure.js:117:21)gyp ERR! stack at /opt/iobroker/node_modules/usocket/node_modules/node-gyp/lib/configure.js:84:9gyp ERR! stack at FSReqCallback.oncomplete (node:fs:187:23)gyp ERR! System Linux 6.1.99-Unraidgyp ERR! command "/usr/bin/node" "/opt/iobroker/node_modules/usocket/node_modules/.bin/node-gyp" "rebuild"

gyp ERR! cwd /opt/iobroker/node_modules/usocketgyp ERR! node -v v20.18.0gyp ERR! node-gyp -v v7.1.2gyp ERR! Node-gyp failed to build your package.gyp ERR! Try to update npm and/or node-gyp and if it does not help file an issue with the package author.

changed 1 package in 4s363 packages are looking for funding run npm fund for details

Updating objects from io-package.json for adapter "shelly" with version "8.3.0"

Update "system.adapter.shelly.0"

upload [16] shelly.admin /opt/iobroker/node_modules/iobroker.shelly/admin/i18n/de/translations.json i18n/de/translations.json application/json

upload [4] shelly.admin /opt/iobroker/node_modules/iobroker.shelly/admin/img/mqttGen2.png img/mqttGen2.png image/png

upload [1] shelly.admin /opt/iobroker/node_modules/iobroker.shelly/admin/jsonConfig.json jsonConfig.json application/json

upload [0] shelly.admin /opt/iobroker/node_modules/iobroker.shelly/admin/shelly.png shelly.png image/png

Process exited with code 0`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants