Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: JSONConfig hat seid Admin v7.1.0 Darstellungsfehler #2728

Open
1 task done
Grizzelbee opened this issue Oct 3, 2024 · 4 comments
Open
1 task done

[bug]: JSONConfig hat seid Admin v7.1.0 Darstellungsfehler #2728

Grizzelbee opened this issue Oct 3, 2024 · 4 comments
Labels

Comments

@Grizzelbee
Copy link

No existing issues.

  • There is no existing issue for my problem.

Describe the bug

Eingefügte Bilder werden nicht mehr richtig skaliert und es wird nach jedem Header ein NewLine ausgeführt - unabhängig von der Konfiguration.

To Reproduce

Öffne Konfigurationsdialog meiner Adapter z.B. dysonAirPurifier, MieleCloudService, Robonect mit Admin >= 7.1.0

Expected behavior

Darstellung der Konfig wie bis incl. Admin v7.0.25

Screenshots & Logfiles

Soll-Zustand (Also Istzustand mit Admin <= 7.0.25):
image
image
image

Ist-Zustand mit Admin >= 7.1.0
image
image
image

Adapter version

unabhängig von der Version

js-controller version

6.0.11

Node version

20..17.0, 22.9.0

Operating system

Linux, Windows

Additional context

No response

@Grizzelbee Grizzelbee added the bug label Oct 3, 2024
@mcm1957
Copy link
Contributor

mcm1957 commented Oct 3, 2024

Are you srue that this is not only caused by width attributes (sm, lg, ..) and screen resolution.

Anyway I do not think that placing 2 Headers side by side and contrcuting some sort of tables this way is a good idea as there always will be small screens which will (and should) insert a line break in between. But this must be eventually discussed.

@GermanBluefox
Copy link
Contributor

GermanBluefox commented Oct 5, 2024

I reverted the behavior on big screens back and applied it only on screens < 600. But your layout is wrong.
You may not rely that fields will be rendered on the same line. Please use tabs or panels for that

BTW: What do you want to achieve with sm: 24? https://github.com/Grizzelbee/ioBroker.dysonairpurifier/blob/master/admin/jsonConfig.json#L36

Only 1-12 values are allowed.

@Grizzelbee
Copy link
Author

Grizzelbee commented Oct 8, 2024

@GermanBluefox , @mcm1957

Okay - you're right I'm going to fix my jsonConfigs.

BUT ... What about the images (Donate-Button in my case)?
They get also suddenly streched since 7.1.0 and there is no (documented) possibility to keep the original size - which makes them looking really ugly.

image

@GermanBluefox
Copy link
Contributor

BUT ... What about the images (Donate-Button in my case)?
They get also suddenly streched since 7.1.0 and there is no (documented) possibility to keep the original size - which makes them looking really ugly.

First: you didn't define any width of the button, so the width is 12 (full width)
Second: you can define

"style": {
    "maxWidth": 150
}

Style is available for every type of control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants