Fix isValid returning true if both positions are in different worlds

Signed-off-by: thebigsmileXD <[email protected]>
inxomnyaa · Oct 28, 2018 · e7a5800 · e7a5800
1 parent cd27009
commit e7a5800
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/plugin.yml b/plugin.yml
@@ -1,7 +1,7 @@
 ---
 name: MagicWE2
 main: xenialdan\MagicWE2\Loader
-version: 6.0.1
+version: 6.0.2
 api: [4.0.0+dev, 3.2.5+dev]
 load: STARTUP
 authors:

diff --git a/src/xenialdan/MagicWE2/Selection.php b/src/xenialdan/MagicWE2/Selection.php
@@ -147,12 +147,10 @@ public function isValid(): bool
             $this->getLevel();
             $this->getPos1();
             $this->getPos2();
-            if ($this->getPos1()->getLevel() === $this->getPos2()->getLevel())
-                return true;
+            return ($this->getPos1()->getLevel() === $this->getLevel() && $this->getPos2()->getLevel() === $this->getLevel());
         } catch (\Exception $e) {
             return false;
         }
-        return true;
     }
 
     /**