-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kebab-case $id fields break Python jschon parser #81
Comments
Hi @gmlewis, surely this is an issue with the Python "jschon" package making assumptions about definition names? Generally speaking, snake-case is the preferred option for URLs as they avoid potential issues with file system case sensitivity and maintain coherence with the domain name. I'd be reluctant to make such a massive change without a rock-solid reason! I would however be in favour of flexibility. If someone would like to override the default snake-case in the reflector configuration, then it makes sense to allow that. This may be a better approach for your PR. |
Thank you for the feedback, @samlown ! |
Structs are currently rendered as kebab-case in the
"$id"
field.For example,
TestUser
becomes:When another field attempts to reference this struct, the Python3.10 "jschon" package resports this error:
but if the
"$id"
line is changed fromtest-user
toTestUser
, then the "jschon" package parses the file successfully.I will work on a PR for this issue.
The text was updated successfully, but these errors were encountered: