Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The definition of uniform distribution is different between the paper and code #276

Open
maoxin7676 opened this issue Jan 13, 2023 · 1 comment · May be fixed by #297
Open

The definition of uniform distribution is different between the paper and code #276

maoxin7676 opened this issue Jan 13, 2023 · 1 comment · May be fixed by #297

Comments

@maoxin7676
Copy link

  • The eq (70 ) in "Lightweight and Optimized Sound Source Localization and Tracking Methods for Open and Closed Microphone Array Configurations" caculates the uniform distribution p = K_hat/(4piK) , where K_hat denotes the number of points scanned, and K the total number of points needed to discretize the entire sphere。
  • The line 153 in mod_sst.c is diffuse_cst = 1.0f / (4.0f * M_PI * ((float) nPointsActive) / ((float) spatialindexes->nPoints)), the value of diffuse_cst is large than 1, i think it should be diffuse_cst = (((float)nPointsActive) / (4.0f * M_PI * (float)spatialindexes->nPoints));
  • Please help confirm whether the above description is correct
@FrancoisGrondin
Copy link
Member

Yes you are right, this seems to be a mistake in the code. It's probably absorbed by some other hand-tuned parameters found empirically, but should be changed to what you said to match the equations in the paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants