-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data validation scenario behaves incorrectly under mock_uss failure #772
Comments
@BenjaminPelletier, regarding point 2. above: I'm assuming that passing I'll look into a way of obtaining a proper |
Yep, it's a larger conceptual issue -- can't parse an intentionally-invalid object. |
#775 proposes to directly mutate the If mutation is not desirable I assume we could use copy.deepcopy(), although I have not tested this yet. |
@BenjaminPelletier this should be solved as the problems identifies by this issue have been addressed by #775 and #774, but could you by any change confirm this on the environment where the problem was originally discovered? I'll leave the issue open until then. |
Observed behavior
USS under test fails Awareness of relevant operational intents scenario because mock_uss has a pre-existing operational intent with intentionally-incorrect data (priority = 1.2) from the previous scenario, Data Validation of GET operational intents by USS, and the USS under test (correctly) cannot parse this invalid operational intent.
Test check
N/A
Difference from expected behavior
a. We should trigger the flight clean up upon scenario failure even if the flight creation call returns 500 (because the flight might have been created before the error was encountered)
.reference
field access) -- we should not attempt to treat a plain dict like an ImplicitDict typea. The underlying issue is that the addition of the
parse_result
argument broke the type-hint contract of the function. Theapply_overrides
type hinting indicates that it returns an ImplicitDictType (specifically, the same type as the providedbase_object
), but whenparse_result
is false, it does not do this -- instead, it returns a plain dict. This is a problem whenop_intent_from_flightrecord
should be returning anf3548_v21.OperationalIntent
and instead returns a dict.Additional context
See attached report for an example of this problem:
sequence.zip
The text was updated successfully, but these errors were encountered: