Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GEN0405 checks #702

Open
BenjaminPelletier opened this issue May 30, 2024 · 0 comments
Open

Add GEN0405 checks #702

BenjaminPelletier opened this issue May 30, 2024 · 0 comments
Labels
automated-testing Related to automated testing tools enhancement New feature or request P2 Normal priority

Comments

@BenjaminPelletier
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, we do not have test coverage for GEN0405 (user notifications upon operational intent state changes).

Describe the solution you'd like
Once the user notifications query in the flight_planning API is available, we can verify GEN0405 compliance by adding a user notification query after an operational intent state change is made. We can limit results to notifications occurring after the action taken by uss_qualifier to cause the state change. We should not count notifications indicating conflicts unless the state change resulted in a conflict.

The documentation of this scenario can be developed before the final version of the API update is merged since the design doc already provides a good description of what it will accomplish, and there is already a PR with a draft that hasn't collected any additional comments currently.

To maximize backwards compatibility, our implementation should be resilient to encountering 404 upon querying user notifications and gracefully skip the GEN0405 checks in that case.

@BenjaminPelletier BenjaminPelletier added enhancement New feature or request automated-testing Related to automated testing tools P2 Normal priority labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-testing Related to automated testing tools enhancement New feature or request P2 Normal priority
Projects
None yet
Development

No branches or pull requests

1 participant