Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test step fragment "Validate flight sharing" does not skip test when required to #442

Closed
mickmis opened this issue Dec 22, 2023 · 0 comments · Fixed by #444
Closed

Test step fragment "Validate flight sharing" does not skip test when required to #442

mickmis opened this issue Dec 22, 2023 · 0 comments · Fixed by #444
Labels
bug Something isn't working

Comments

@mickmis
Copy link
Contributor

mickmis commented Dec 22, 2023

Describe the bug
Test step fragment described by validate_shared_operational_intent.md is supposed to interrupt its execution and skip the test step fragment when a new or modified operational intent is not found, but only if that is explicitly allowed by the test scenario.

In scenarios/astm/utm/test_steps.py the recent PR #376 extracted some logic out of expect_shared into _operational_intent_shared_check. Previously the returns would interrupt the execution of the flow because they were in expect_shared, but now they are not and they do not interrupt the execution anymore:

self._scenario.record_note(
f"{self._flight_planner.participant_id} skipped step",
f"No new operational intent was found in DSS, instructed to skip test step '{self._test_step}'.",
)
self._scenario.end_test_step()
return None

self._scenario.record_note(
f"{self._flight_planner.participant_id} skipped step",
f"Operational intent reference with ID {self._orig_oi_ref.id} not found in DSS, instructed to skip test step '{self._test_step}'.",
)
self._scenario.end_test_step()
return None

Possible solution
Interrupt execution in callers of _operational_intent_shared_check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant