From de7b288d2b6a52a1c69981143bf211d30fc37be9 Mon Sep 17 00:00:00 2001 From: Julien Perrochet Date: Thu, 14 Sep 2023 16:57:22 +0200 Subject: [PATCH] [uss_qualifier] add NET0450 to existing checks --- .../scenarios/astm/netrid/display_data_evaluator.py | 11 ++++++++++- .../scenarios/astm/netrid/v19/nominal_behavior.md | 8 ++++++-- .../scenarios/astm/netrid/v22a/nominal_behavior.md | 8 ++++++-- .../uss_qualifier/suites/astm/netrid/f3411_19.md | 7 ++++++- .../uss_qualifier/suites/astm/netrid/f3411_22a.md | 7 ++++++- .../suites/uspace/network_identification.md | 7 ++++++- .../uss_qualifier/suites/uspace/required_services.md | 7 ++++++- 7 files changed, 46 insertions(+), 9 deletions(-) diff --git a/monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py b/monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py index 82265dbb32..75414950e8 100644 --- a/monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py +++ b/monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py @@ -365,9 +365,18 @@ def _evaluate_normal_observation( ] observed_position = mapping.observed_flight.most_recent_position injected_position = injected_telemetry.position + + with self._test_scenario.check("Altitude is present") as check: + if "alt" not in injected_position: + check.record_failed( + summary="Displayed flight is missing altitude", + severity=Severity.Medium, + details=f"Displayed data for injected flight {mapping.injected_flight.flight.injection_id} in test {mapping.injected_flight.test_id} at {injected_telemetry.timestamp} does not have altitude", + ) + if "alt" in observed_position: with self._test_scenario.check( - "Observed altitude", + "Correct up-to-date altitude", [ observer.participant_id, mapping.injected_flight.uss_participant_id, diff --git a/monitoring/uss_qualifier/scenarios/astm/netrid/v19/nominal_behavior.md b/monitoring/uss_qualifier/scenarios/astm/netrid/v19/nominal_behavior.md index 1318567e73..27fe4e9d30 100644 --- a/monitoring/uss_qualifier/scenarios/astm/netrid/v19/nominal_behavior.md +++ b/monitoring/uss_qualifier/scenarios/astm/netrid/v19/nominal_behavior.md @@ -130,9 +130,13 @@ The timestamps of the injected telemetry usually start in the future. If a flig **[astm.f3411.v19.NET0290](../../../../requirements/astm/f3411/v19.md)** requires a SP uses Telemetry vs extrapolation when telemetry is present. -#### Observed altitude check +#### Altitude is present check -**[astm.f3411.v19.NET0470](../../../../requirements/astm/f3411/v19.md)** requires that a Display Provider provides any specified data fields in accordance with the common data dictionary when responding to a Display Application. If the observed altitude of a flight does not match the altitude of the injected telemetry, this check will fail. +Failure to report the altitude of a flight is a violation of **[astm.f3411.v19.NET0470](../../../../requirements/astm/f3411/v19.md)**. + +#### Correct up-to-date altitude check + +If the observed altitude of a flight does not match the altitude of the injected telemetry, the display provider is not providing precise and up-to-date information, and thus does not respect **[astm.f3411.v19.NET0450](../../../../requirements/astm/f3411/v19.md)**. #### Area too large check diff --git a/monitoring/uss_qualifier/scenarios/astm/netrid/v22a/nominal_behavior.md b/monitoring/uss_qualifier/scenarios/astm/netrid/v22a/nominal_behavior.md index beb41a6b49..16e074d320 100644 --- a/monitoring/uss_qualifier/scenarios/astm/netrid/v22a/nominal_behavior.md +++ b/monitoring/uss_qualifier/scenarios/astm/netrid/v22a/nominal_behavior.md @@ -158,9 +158,13 @@ The timestamps of the injected telemetry usually start in the future. If a flig **[astm.f3411.v22a.NET0290](../../../../requirements/astm/f3411/v22a.md)** requires a SP uses Telemetry vs extrapolation when telemetry is present. -#### Observed altitude check +#### Altitude is present check -**[astm.f3411.v22a.NET0470](../../../../requirements/astm/f3411/v22a.md)** requires that a Display Provider provides any specified data fields in accordance with the common data dictionary when responding to a Display Application. If the observed altitude of a flight does not match the altitude of the injected telemetry, this check will fail. +Failure to report the altitude of a flight is a violation of **[astm.f3411.v22a.NET0470](../../../../requirements/astm/f3411/v22a.md)**. + +#### Correct up-to-date altitude check + +If the observed altitude of a flight does not match the altitude of the injected telemetry, the display provider is not providing precise and up-to-date information, and thus does not respect **[astm.f3411.v22a.NET0450](../../../../requirements/astm/f3411/v22a.md)**. #### Area too large check diff --git a/monitoring/uss_qualifier/suites/astm/netrid/f3411_19.md b/monitoring/uss_qualifier/suites/astm/netrid/f3411_19.md index 089ea93df4..08590286d5 100644 --- a/monitoring/uss_qualifier/suites/astm/netrid/f3411_19.md +++ b/monitoring/uss_qualifier/suites/astm/netrid/f3411_19.md @@ -21,7 +21,7 @@ Checked in - astm
.f3411
.v19 + astm
.f3411
.v19 A2-6-1,1a Implemented ASTM F3411-19 NetRID DSS interoperability @@ -206,6 +206,11 @@ Implemented ASTM F3411-19 NetRID aggregate checks + + NET0450 + Implemented + ASTM NetRID nominal behavior + NET0470 Implemented diff --git a/monitoring/uss_qualifier/suites/astm/netrid/f3411_22a.md b/monitoring/uss_qualifier/suites/astm/netrid/f3411_22a.md index 6096cf8563..d98cd35b84 100644 --- a/monitoring/uss_qualifier/suites/astm/netrid/f3411_22a.md +++ b/monitoring/uss_qualifier/suites/astm/netrid/f3411_22a.md @@ -21,7 +21,7 @@ Checked in - astm
.f3411
.v22a + astm
.f3411
.v22a A2-6-1,1a Implemented ASTM F3411-22a NetRID DSS interoperability @@ -246,6 +246,11 @@ Implemented ASTM F3411-22a NetRID aggregate checks + + NET0450 + Implemented + ASTM NetRID nominal behavior + NET0470 Implemented diff --git a/monitoring/uss_qualifier/suites/uspace/network_identification.md b/monitoring/uss_qualifier/suites/uspace/network_identification.md index ec7130edb8..601d57ed18 100644 --- a/monitoring/uss_qualifier/suites/uspace/network_identification.md +++ b/monitoring/uss_qualifier/suites/uspace/network_identification.md @@ -16,7 +16,7 @@ Checked in - astm
.f3411
.v22a + astm
.f3411
.v22a A2-6-1,1a Implemented ASTM F3411-22a NetRID DSS interoperability @@ -241,6 +241,11 @@ Implemented ASTM F3411-22a NetRID aggregate checks + + NET0450 + Implemented + ASTM NetRID nominal behavior + NET0470 Implemented diff --git a/monitoring/uss_qualifier/suites/uspace/required_services.md b/monitoring/uss_qualifier/suites/uspace/required_services.md index 1e24a9d65f..c7c7353241 100644 --- a/monitoring/uss_qualifier/suites/uspace/required_services.md +++ b/monitoring/uss_qualifier/suites/uspace/required_services.md @@ -17,7 +17,7 @@ Checked in - astm
.f3411
.v22a + astm
.f3411
.v22a A2-6-1,1a Implemented ASTM F3411-22a NetRID DSS interoperability @@ -242,6 +242,11 @@ Implemented ASTM F3411-22a NetRID aggregate checks + + NET0450 + Implemented + ASTM NetRID nominal behavior + NET0470 Implemented