From 3c5de1f4f2ec2e09db1762b683ed95a9f222950b Mon Sep 17 00:00:00 2001 From: Julien Perrochet Date: Thu, 14 Sep 2023 16:57:22 +0200 Subject: [PATCH] [uss_qualifier] add NET0450 to existing checks --- .../scenarios/astm/netrid/display_data_evaluator.py | 4 +++- .../scenarios/astm/netrid/v19/nominal_behavior.md | 6 ++++-- .../scenarios/astm/netrid/v22a/nominal_behavior.md | 6 ++++-- monitoring/uss_qualifier/suites/astm/netrid/f3411_19.md | 9 +++++++-- monitoring/uss_qualifier/suites/astm/netrid/f3411_22a.md | 9 +++++++-- .../suites/uspace/network_identification.md | 9 +++++++-- .../uss_qualifier/suites/uspace/required_services.md | 9 +++++++-- 7 files changed, 39 insertions(+), 13 deletions(-) diff --git a/monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py b/monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py index 82265dbb32..298438cd79 100644 --- a/monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py +++ b/monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py @@ -365,9 +365,11 @@ def _evaluate_normal_observation( ] observed_position = mapping.observed_flight.most_recent_position injected_position = injected_telemetry.position + # TODO confirm ALT is optional with Ben. if "alt" in observed_position: + # TODO up to date altitude seems to check for NET0450 rather than NET0470. Confirm with Ben with self._test_scenario.check( - "Observed altitude", + "Correct observed altitude", [ observer.participant_id, mapping.injected_flight.uss_participant_id, diff --git a/monitoring/uss_qualifier/scenarios/astm/netrid/v19/nominal_behavior.md b/monitoring/uss_qualifier/scenarios/astm/netrid/v19/nominal_behavior.md index 1318567e73..87822c4809 100644 --- a/monitoring/uss_qualifier/scenarios/astm/netrid/v19/nominal_behavior.md +++ b/monitoring/uss_qualifier/scenarios/astm/netrid/v19/nominal_behavior.md @@ -130,9 +130,11 @@ The timestamps of the injected telemetry usually start in the future. If a flig **[astm.f3411.v19.NET0290](../../../../requirements/astm/f3411/v19.md)** requires a SP uses Telemetry vs extrapolation when telemetry is present. -#### Observed altitude check +#### Correct observed altitude check -**[astm.f3411.v19.NET0470](../../../../requirements/astm/f3411/v19.md)** requires that a Display Provider provides any specified data fields in accordance with the common data dictionary when responding to a Display Application. If the observed altitude of a flight does not match the altitude of the injected telemetry, this check will fail. +If the observed altitude of a flight does not match the altitude of the injected telemetry, the display provider is not providing precise and up-to-date information, and thus does not respect **[astm.f3411.v19.NET0450](../../../../requirements/astm/f3411/v19.md)**. + +TODO: check if the following needs its own check that would verify that the altitude field is present: **[astm.f3411.v19.NET0470](../../../../requirements/astm/f3411/v19.md)** requires that a Display Provider provides any specified data fields in accordance with the common data dictionary when responding to a Display Application. #### Area too large check diff --git a/monitoring/uss_qualifier/scenarios/astm/netrid/v22a/nominal_behavior.md b/monitoring/uss_qualifier/scenarios/astm/netrid/v22a/nominal_behavior.md index beb41a6b49..b69fe927a6 100644 --- a/monitoring/uss_qualifier/scenarios/astm/netrid/v22a/nominal_behavior.md +++ b/monitoring/uss_qualifier/scenarios/astm/netrid/v22a/nominal_behavior.md @@ -158,9 +158,11 @@ The timestamps of the injected telemetry usually start in the future. If a flig **[astm.f3411.v22a.NET0290](../../../../requirements/astm/f3411/v22a.md)** requires a SP uses Telemetry vs extrapolation when telemetry is present. -#### Observed altitude check +#### Correct observed altitude check -**[astm.f3411.v22a.NET0470](../../../../requirements/astm/f3411/v22a.md)** requires that a Display Provider provides any specified data fields in accordance with the common data dictionary when responding to a Display Application. If the observed altitude of a flight does not match the altitude of the injected telemetry, this check will fail. +If the observed altitude of a flight does not match the altitude of the injected telemetry, the display provider is not providing precise and up-to-date information, and thus does not respect **[astm.f3411.v22a.NET0450](../../../../requirements/astm/f3411/v22a.md)**. + +TODO: confirm what do to with **[astm.f3411.v22a.NET0470](../../../../requirements/astm/f3411/v22a.md)** requires that a Display Provider provides any specified data fields in accordance with the common data dictionary when responding to a Display Application. If the observed altitude of a flight does not match the altitude of the injected telemetry, this check will fail. #### Area too large check diff --git a/monitoring/uss_qualifier/suites/astm/netrid/f3411_19.md b/monitoring/uss_qualifier/suites/astm/netrid/f3411_19.md index 089ea93df4..804ab2ca24 100644 --- a/monitoring/uss_qualifier/suites/astm/netrid/f3411_19.md +++ b/monitoring/uss_qualifier/suites/astm/netrid/f3411_19.md @@ -21,7 +21,7 @@ Checked in - astm
.f3411
.v19 + astm
.f3411
.v19 A2-6-1,1a Implemented ASTM F3411-19 NetRID DSS interoperability @@ -206,9 +206,14 @@ Implemented ASTM F3411-19 NetRID aggregate checks + + NET0450 + Planned + ASTM NetRID nominal behavior + NET0470 - Implemented + Planned ASTM NetRID nominal behavior diff --git a/monitoring/uss_qualifier/suites/astm/netrid/f3411_22a.md b/monitoring/uss_qualifier/suites/astm/netrid/f3411_22a.md index 6096cf8563..ac1f03d2ac 100644 --- a/monitoring/uss_qualifier/suites/astm/netrid/f3411_22a.md +++ b/monitoring/uss_qualifier/suites/astm/netrid/f3411_22a.md @@ -21,7 +21,7 @@ Checked in - astm
.f3411
.v22a + astm
.f3411
.v22a A2-6-1,1a Implemented ASTM F3411-22a NetRID DSS interoperability @@ -246,9 +246,14 @@ Implemented ASTM F3411-22a NetRID aggregate checks + + NET0450 + Planned + ASTM NetRID nominal behavior + NET0470 - Implemented + Planned ASTM NetRID nominal behavior diff --git a/monitoring/uss_qualifier/suites/uspace/network_identification.md b/monitoring/uss_qualifier/suites/uspace/network_identification.md index ec7130edb8..7df1298ebd 100644 --- a/monitoring/uss_qualifier/suites/uspace/network_identification.md +++ b/monitoring/uss_qualifier/suites/uspace/network_identification.md @@ -16,7 +16,7 @@ Checked in - astm
.f3411
.v22a + astm
.f3411
.v22a A2-6-1,1a Implemented ASTM F3411-22a NetRID DSS interoperability @@ -241,9 +241,14 @@ Implemented ASTM F3411-22a NetRID aggregate checks + + NET0450 + Planned + ASTM NetRID nominal behavior + NET0470 - Implemented + Planned ASTM NetRID nominal behavior diff --git a/monitoring/uss_qualifier/suites/uspace/required_services.md b/monitoring/uss_qualifier/suites/uspace/required_services.md index 1e24a9d65f..83b022d95b 100644 --- a/monitoring/uss_qualifier/suites/uspace/required_services.md +++ b/monitoring/uss_qualifier/suites/uspace/required_services.md @@ -17,7 +17,7 @@ Checked in - astm
.f3411
.v22a + astm
.f3411
.v22a A2-6-1,1a Implemented ASTM F3411-22a NetRID DSS interoperability @@ -242,9 +242,14 @@ Implemented ASTM F3411-22a NetRID aggregate checks + + NET0450 + Planned + ASTM NetRID nominal behavior + NET0470 - Implemented + Planned ASTM NetRID nominal behavior