-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AllowHTTP flag to be more clear #788
Comments
Merged
BenjaminPelletier
added
P2
Normal priority
feature
Issue would improve software
P3
Lower priority
dss
Relating to one of the DSS implementations
and removed
P2
Normal priority
labels
Sep 20, 2022
barroco
pushed a commit
that referenced
this issue
Aug 8, 2024
- Rename all usages of EnableHTTP to AllowHTTPBaseUrls - Add command-line flag, allow_http_base_urls - Deprecate command-line flag, enable_http, in favor of allow_http_base_urls Clients of core-service will need to update the command-line parameter, enable_http to allow_http_base_urls, namely Monitoring – core_service.sh L21/33. Created for Issue #788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I feel like this flag may benefit to be renamed since it is only used to disable URLs validation. I would propose to rename it as AllowHTTP or AllowHTTPBaseUrls to prevent confusion. Indeed, I got mislead thinking that this was linked to the listening protocol of the DSS server.
Originally posted by @barroco in #784 (comment)
The text was updated successfully, but these errors were encountered: