From 67e01d4c6bc2234f02edf0fd703c79ed6b33116b Mon Sep 17 00:00:00 2001
From: isc-pbarton <9560941+isc-pbarton@users.noreply.github.com>
Date: Tue, 5 Sep 2023 13:50:22 -0400
Subject: [PATCH 1/3] option to make settings read-only in web UI

---
 cls/SourceControl/Git/Settings.cls |  5 +++
 cls/SourceControl/Git/Utils.cls    |  6 ++++
 csp/gitprojectsettings.csp         | 50 +++++++++++++++++-------------
 3 files changed, 40 insertions(+), 21 deletions(-)

diff --git a/cls/SourceControl/Git/Settings.cls b/cls/SourceControl/Git/Settings.cls
index 15897a04..8b17d4e4 100644
--- a/cls/SourceControl/Git/Settings.cls
+++ b/cls/SourceControl/Git/Settings.cls
@@ -20,6 +20,9 @@ Property pullEventClass As %String(MAXLEN = 255) [ InitialExpression = {##class(
 /// Character to replace % symbol when importing %-classes into the file systems
 Property percentClassReplace As %String [ InitialExpression = {##class(SourceControl.Git.Utils).PercentClassReplace()} ];
 
+/// Git project settings are read-only in the web user interface
+Property settingsUIReadOnly As %Boolean [ InitialExpression = {##class(SourceControl.Git.Utils).SettingsUIReadOnly()} ];
+
 /// Attribution: Git username for user ${username}
 Property gitUserName As %String(MAXLEN = 255) [ InitialExpression = {##class(SourceControl.Git.Utils).GitUserName()} ];
 
@@ -72,6 +75,7 @@ Method %Save() As %Status
     set @storage@("settings","ssh","privateKeyFile") = ..privateKeyFile
     set @storage@("settings","pullEventClass") = ..pullEventClass
     set @storage@("settings","percentClassReplace") = ..percentClassReplace
+    set @storage@("settings","settingsUIReadOnly") = ..settingsUIReadOnly
 
     kill @##class(SourceControl.Git.Utils).MappingsNode()
     merge @##class(SourceControl.Git.Utils).MappingsNode() = ..Mappings
@@ -168,3 +172,4 @@ Method OnAfterConfigure() As %Boolean
 }
 
 }
+
diff --git a/cls/SourceControl/Git/Utils.cls b/cls/SourceControl/Git/Utils.cls
index ab159efe..6d89d18c 100644
--- a/cls/SourceControl/Git/Utils.cls
+++ b/cls/SourceControl/Git/Utils.cls
@@ -67,6 +67,11 @@ ClassMethod PercentClassReplace() As %Status [ CodeMode = expression ]
 $Get(@..#Storage@("settings","percentClassReplace"), "")
 }
 
+ClassMethod SettingsUIReadOnly() As %Status [ CodeMode = expression ]
+{
+$Get(@..#Storage@("settings","settingsUIReadOnly"), 0)
+}
+
 /// Returns the current (or previous) value of the flag.
 ClassMethod Locked(newFlagValue As %Boolean) As %Boolean
 {
@@ -1983,3 +1988,4 @@ ClassMethod BuildCEInstallationPackage(ByRef destination As %String) As %Status
 }
 
 }
+
diff --git a/csp/gitprojectsettings.csp b/csp/gitprojectsettings.csp
index 14032beb..ad441031 100644
--- a/csp/gitprojectsettings.csp
+++ b/csp/gitprojectsettings.csp
@@ -62,34 +62,35 @@ body {
  set webuiURL = ##class(SourceControl.Git.WebUIDriver).GetURLPrefix(%request, webuiURL)
 
  set settings = ##class(SourceControl.Git.Settings).%New()
-
- if $Data(%request.Data("gitsettings",1)) {
-    for param="gitBinPath","namespaceTemp","privateKeyFile","pullEventClass","percentClassReplace","gitUserName","gitUserEmail"{
-        set $Property(settings,param) = $Get(%request.Data(param,1))
-    }
-    set i = 1
-    set param = "NoFolders"
-    kill settings.Mappings
-    
-    while ( $Get(%request.Data("MappingsExt",i)) '= "" ){
-        if ($Get(%request.Data(param,i)) = "NoFolders"){
-            set settings.Mappings($Get(%request.Data("MappingsExt",i)), $Get(%request.Data("MappingsCov",i)), $Get(%request.Data(param,i))) = 1
+ if ('settings.settingsUIReadOnly) {
+    if $Data(%request.Data("gitsettings",1)) {
+        for param="gitBinPath","namespaceTemp","privateKeyFile","pullEventClass","percentClassReplace","gitUserName","gitUserEmail"{
+            set $Property(settings,param) = $Get(%request.Data(param,1))
+        }
+        set i = 1
+        set param = "NoFolders"
+        kill settings.Mappings
+        
+        while ( $Get(%request.Data("MappingsExt",i)) '= "" ){
+            if ($Get(%request.Data(param,i)) = "NoFolders"){
+                set settings.Mappings($Get(%request.Data("MappingsExt",i)), $Get(%request.Data("MappingsCov",i)), $Get(%request.Data(param,i))) = 1
+            }
+            set settings.Mappings($Get(%request.Data("MappingsExt",i)), $Get(%request.Data("MappingsCov",i))) = $Get(%request.Data("MappingsPath",i))
+            set i = i+1
         }
-        set settings.Mappings($Get(%request.Data("MappingsExt",i)), $Get(%request.Data("MappingsCov",i))) = $Get(%request.Data("MappingsPath",i))
-        set i = i+1
+        do settings.%Save()
     }
-    do settings.%Save()
 }
 </server>
 <div class = 'container'>    
-    <form method='post'>
+    <form id="settingsForm" method='post'>
         <input type="hidden" name="Namespace" value="#(..EscapeHTML(namespace))#" />
         <input type="hidden" name="gitsettings" value="1" />
         <div class="col-sm-12"><br></div>
         <div class="row">
             <div class="col-sm-1"></div>
             <div class="col-sm-8">
-                <h1>Git Project Settings</h1>
+                <h1>Git Project Settings #($select(settings.settingsUIReadOnly:"(Read-Only)",1:""))#</h1>
             </div>
             <div class="col-sm-2">
                 <button class="btn btn-lg btn-outline-dark" id="goToWebUI">Go to WebUI
@@ -367,11 +368,13 @@ body {
 
         <br/>
 
-        <div class="form-group row mb-3">
-            <div class="col-sm-12 text-center">
-                <input type='submit' class="btn-lg btn-primary" value = 'Save'/>
+        <csp:if condition="'settings.settingsUIReadOnly">
+            <div class="form-group row mb-3">
+                <div class="col-sm-12 text-center">
+                    <input type='submit' class="btn-lg btn-primary" value = 'Save'/>
+                </div>
             </div>
-        </div>
+        </csp:if>
         
     </form>
     <csp:if condition='$D(%request.Data("gitsettings",1)) && (##class(SourceControl.Git.Utils).NeedSettings() = 0)'>
@@ -435,6 +438,11 @@ $(function () {
 });
 $(function()
 {
+    if (#(settings.settingsUIReadOnly)#) {
+        $(document).ready( function() {
+            $("#settingsForm input, select").attr("disabled",true);
+        })
+    }
     $(document).on('click', '.btn-add', function(e)
     {
         e.preventDefault();

From 6b639376927b3830cbfe32ebc8754ed5356c4f42 Mon Sep 17 00:00:00 2001
From: isc-pbarton <9560941+isc-pbarton@users.noreply.github.com>
Date: Tue, 5 Sep 2023 13:59:42 -0400
Subject: [PATCH 2/3] updated changelog

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9e4f77d4..160941fa 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 - Web UI includes a "Push Branch" button for local branches that are ahead of upstream
+- Support for making the Settings UI read-only through `##class(SourceControl.Git.API).Configure()` (#258)
 
 ### Fixed
 - Studio export path doesn't get weird mixed slahes on Windows (#252)

From 5c435e48669bb132604f864b828fcf7d3480a00f Mon Sep 17 00:00:00 2001
From: isc-pbarton <9560941+isc-pbarton@users.noreply.github.com>
Date: Mon, 18 Sep 2023 15:14:47 -0400
Subject: [PATCH 3/3] Only namespace-wide settings are read-only

---
 csp/gitprojectsettings.csp | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/csp/gitprojectsettings.csp b/csp/gitprojectsettings.csp
index 5a6c4f7e..c61f55d1 100644
--- a/csp/gitprojectsettings.csp
+++ b/csp/gitprojectsettings.csp
@@ -62,9 +62,12 @@ body {
  set webuiURL = ##class(SourceControl.Git.WebUIDriver).GetURLPrefix(%request, webuiURL)
 
  set settings = ##class(SourceControl.Git.Settings).%New()
- if ('settings.settingsUIReadOnly) {
-    if $Data(%request.Data("gitsettings",1)) {
-        for param="gitBinPath","namespaceTemp","privateKeyFile","pullEventClass","percentClassReplace","gitUserName","gitUserEmail"{
+ if $Data(%request.Data("gitsettings",1)) {
+    for param="gitUserName","gitUserEmail" {
+        set $Property(settings,param) = $Get(%request.Data(param,1))
+    }
+    if ('settings.settingsUIReadOnly) {
+        for param="gitBinPath","namespaceTemp","privateKeyFile","pullEventClass","percentClassReplace" {
             set $Property(settings,param) = $Get(%request.Data(param,1))
         }
         set i = 1
@@ -80,8 +83,8 @@ body {
         }
             set i = i+1
         }
-        do settings.%Save()
     }
+    do settings.%Save()
 }
 </server>
 <div class = 'container'>    
@@ -92,7 +95,7 @@ body {
         <div class="row">
             <div class="col-sm-1"></div>
             <div class="col-sm-8">
-                <h1>Git Project Settings #($select(settings.settingsUIReadOnly:"(Read-Only)",1:""))#</h1>
+                <h1>Git Project Settings</h1>
             </div>
             <div class="col-sm-2">
                 <button class="btn btn-lg btn-outline-dark" id="goToWebUI">Go to WebUI
@@ -109,10 +112,11 @@ body {
         <div class="row">
             <div class="col-sm-1"></div>
             <div class="col-sm-11">
-                <h3>Settings for namespace #(..EscapeHTML(namespace))#</h3><br/>
+                <h3>Settings for namespace #(..EscapeHTML(namespace))# #($select(settings.settingsUIReadOnly:"(read-only)",1:""))#</h3><br/>
             </div>
         </div>
 
+        <fieldset id="namespaceSettings">
         <div class="form-group row mb-3">
             <div class="col-sm-1"></div>
             <label for="gitBinPath" class="col-sm-3 col-form-label"  data-toggle="tooltip" data-placement="top" title="Absolute path to the Git executable">Path to git.exe</label>
@@ -337,6 +341,7 @@ body {
                 }
             </script>        
         </div>
+        </fieldset>
 
         <br/>
         <div class="row">
@@ -355,6 +360,7 @@ body {
 
         <br/>
 
+        <fieldset id="userSettings">
         <div class="form-group row mb-3">
             <div class="col-sm-1"></div>
             <label for="gitUserName" class="col-sm-3 col-form-label"  data-toggle="tooltip" data-placement="top" title="Firstname Lastname">Git Committer Name </label>
@@ -372,14 +378,13 @@ body {
         </div>
 
         <br/>
+        </fieldset>
 
-        <csp:if condition="'settings.settingsUIReadOnly">
-            <div class="form-group row mb-3">
-                <div class="col-sm-12 text-center">
-                    <input type='submit' class="btn-lg btn-primary" value = 'Save'/>
-                </div>
+        <div class="form-group row mb-3">
+            <div class="col-sm-12 text-center">
+                <input type='submit' class="btn-lg btn-primary" value = 'Save'/>
             </div>
-        </csp:if>
+        </div>
         
     </form>
     <csp:if condition='$D(%request.Data("gitsettings",1)) && (##class(SourceControl.Git.Utils).NeedSettings() = 0)'>
@@ -445,7 +450,7 @@ $(function()
 {
     if (#(settings.settingsUIReadOnly)#) {
         $(document).ready( function() {
-            $("#settingsForm input, select").attr("disabled",true);
+            $("#namespaceSettings input, select").attr("disabled",true);
         })
     }
     $(document).on('click', '.btn-add', function(e)