You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Define a common Feature model for use across the project (crawler client, server, other tools).
Can be a 'vanilla' dataclass, a pydantic model, or an ORM model. All sides of the workflow should agree on what a Feature looks like and how it is structured.
We should review this as a team to make sure that it matches the table schema exactly, and that it contains all of the features we will need going forward.
A common and importable model will require a minor refactor of the existing crawler port.
The text was updated successfully, but these errors were encountered:
Define a common
Feature
model for use across the project (crawler client, server, other tools).Can be a 'vanilla'
dataclass
, a pydantic model, or an ORM model. All sides of the workflow should agree on what aFeature
looks like and how it is structured.The python port of the crawler defines a SQLAlchemy ORM model (see https://github.com/gzt5142/nldi-crawler-py/blob/b87418874cb90cbf32ce8ea25bdbbddcef19c355/src/nldi_crawler/ingestor.py#L62
We should review this as a team to make sure that it matches the table schema exactly, and that it contains all of the features we will need going forward.
A common and importable model will require a minor refactor of the existing crawler port.
The text was updated successfully, but these errors were encountered: