Conditionally fetch blog RSS feed #10015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Thanks @astatide!
When testing this, I wasn't able to trigger a 304 response from the blog server. Were you able to?
Instead of all of these changes, can you instead modify the cache timeout to last for a day (as per this comment)?
Staff will be able to evict the cache entry for the blog posts if ever needed (Note for staff: Cache key for blog posts is upstream.get_blog_feeds$).
jimchamp
added
the
Needs: Submitter Input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2831
refactor! This wraps the existing
_get_blog_feedsfunctionality via an enclosure that caches the result and date so a conditional get request can be performed.Technical
This was done under an assumption that I probably should not change
cache.memcache_memoizeand leave it as is. This technically uses an alternate sort of 'cache' mechanism in that we're leaving the results inside the closure.Also? It's been a hot minute since I've changed some python code, so help testing this PR to make sure it works would be really appreciated!
Testing
Screenshot
Stakeholders