Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in with Google button isn't centered on mobile #10071

Open
RayBB opened this issue Nov 23, 2024 · 7 comments · May be fixed by #10077 or #10079
Open

Sign in with Google button isn't centered on mobile #10071

RayBB opened this issue Nov 23, 2024 · 7 comments · May be fixed by #10077 or #10079
Assignees
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] registration Type: Bug Something isn't working. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Nov 23, 2024

Problem

Probably is a relatively easy fix.

Screenshot_20241122-193340

Reproducing the bug

  1. Go to ...
  2. Do ...
  • Expected behavior:
  • Actual behavior:

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N):
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@RayBB RayBB added Type: Bug Something isn't working. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 23, 2024
@shikharchaurasia
Copy link

Hello, I would like to work on this issue. Could this please be assigned to me?

@RayBB
Copy link
Collaborator Author

RayBB commented Nov 23, 2024

@shikharchaurasia you're assigned. Good luck!

@ronibhakta1
Copy link

@RayBB i am ready to merge it can you assign it to me?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Nov 23, 2024
@shikharchaurasia
Copy link

shikharchaurasia commented Nov 23, 2024

Hi @RayBB,

I have figured the issue and tested a fix locally which seems to work.

Here is my triage of the issue:

Problem

Sign in with Google button isn't centered on mobile/desktop.
image
(Desktop view - notice the Google sign in option is aligned towards left)
image
(Mobile view - notice the Google sign in option is aligned towards left)

Reproducing the bug

  1. Launch https://openlibrary.org/account/login on browser. Alternatively, you can run docker compose up, and launch localhost:8080 and navigate to login page at http://localhost:8080/account/login
  2. Observe the third party Google login option.

Expected Behavior: The third party Google login option is centered relative to the login form.
Actual Behavior: The third party Google login option is NOT centered relative to the login form.

Context
Browser (Chrome, Safari, Firefox, etc): Tested on Google Chrome and Firefox.
OS (Windows, Mac, etc): Windows
Logged in (Y/N): N
Environment (prod, dev, local): Prod, Dev and Local.

Breakdown
Requirements Checklist

  • Analyze the styles applied to the third party sign in option resulting in a non-centered display render.
  • Make necessary fixes to center the third party sign in option relative to the form.

Relevant Files:

  • templates/account/ia_thirdparty_logins.html
  • templates/login.html

Stakeholders:

shikharchaurasia added a commit to shikharchaurasia/openlibrary that referenced this issue Nov 23, 2024
@shikharchaurasia shikharchaurasia linked a pull request Nov 23, 2024 that will close this issue
@shikharchaurasia
Copy link

Hi @RayBB - I have put up a PR that fixes this issue, and is up for review: #10079
Please review this when you get the chance and let me know if anything else needs to be addressed.
Thank you! :)

@mekarpeles
Copy link
Member

Thank you @shikharchaurasia :) we'll get the PR assigned to a reviewer and offer feedback shortly.

P.S. Thank you also @ronibhakta1 for your enthusiasm, I hope we can find another issue to support you on!

@mekarpeles mekarpeles added Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] registration and removed Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead Needs: Response Issues which require feedback from lead labels Nov 25, 2024
@ronibhakta1
Copy link

P.S. Thank you also @ronibhakta1 for your enthusiasm, I hope we can find another issue to support you on!
looking forward for that :)

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Nov 26, 2024
@RayBB RayBB added Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] and removed Needs: Response Issues which require feedback from lead labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] registration Type: Bug Something isn't working. [managed]
Projects
None yet
4 participants