-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests #18
Comments
The branch had been merged in, so they're all in the commit history for |
Ok great, that makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened to the unit tests? I noticed the branch is gone.
A lot of those tests were testing balance/account/store logic as well as packet construction very thoroughly. If they are gone, it is very possible that somebody could edit the plugin and cause a minor breaking change (like balance logic not being calculated properly or persisted to the store) and the integration tests would still pass. I feel this could be pretty dangerous considering the plugin is in beta and will have updates.
The text was updated successfully, but these errors were encountered: