From bc87a66ce00e2c982a70c9e3d001b5721740997c Mon Sep 17 00:00:00 2001 From: Cody Miller Date: Mon, 26 Feb 2024 11:31:05 -0500 Subject: [PATCH 1/3] fix: backwards compatibility with older AGPs --- android/src/main/AndroidManifest.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/android/src/main/AndroidManifest.xml b/android/src/main/AndroidManifest.xml index 0a0938ae..c894b62c 100644 --- a/android/src/main/AndroidManifest.xml +++ b/android/src/main/AndroidManifest.xml @@ -1,3 +1,4 @@ - + From c973e5af845fc0fe5f87597bac44989009b8abcf Mon Sep 17 00:00:00 2001 From: Cody Miller Date: Mon, 26 Feb 2024 11:41:00 -0500 Subject: [PATCH 2/3] hotfix: apply namespace to all AGPs --- android/build.gradle | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index fb1f1e0e..b707505c 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -23,11 +23,7 @@ def safeExtGet(prop, fallback) { } android { - // Compatibility for AGP v. <4.2/Gradle 8 - def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION.tokenize('.')[0].toInteger() - if (agpVersion >= 7) { - namespace 'com.intercom.reactnative' - } + namespace 'com.intercom.reactnative' compileSdkVersion safeExtGet('IntercomReactNative_compileSdkVersion', 34) defaultConfig { From 0613553b153480be2ac6631b6871c521482f980c Mon Sep 17 00:00:00 2001 From: Cody Miller Date: Mon, 26 Feb 2024 11:41:59 -0500 Subject: [PATCH 3/3] fix: revert manifest changes Reverting these as I personally think just setting namespace for all AGPs is a better solution --- android/src/main/AndroidManifest.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/android/src/main/AndroidManifest.xml b/android/src/main/AndroidManifest.xml index c894b62c..0a0938ae 100644 --- a/android/src/main/AndroidManifest.xml +++ b/android/src/main/AndroidManifest.xml @@ -1,4 +1,3 @@ - +