Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make client class disposable and call httpClient.Dispose() #134

Open
slegay opened this issue Jul 6, 2018 · 1 comment
Open

Please make client class disposable and call httpClient.Dispose() #134

slegay opened this issue Jul 6, 2018 · 1 comment

Comments

@slegay
Copy link

slegay commented Jul 6, 2018

The client class uses an instance of HttpClient, which implements IDisposable, but never disposes of it. I am not sure what the memory and networking consequences are when creating a bunch of HttpClient instances without proper disposal, but it might be a good idea to implement IDisposable and allow developers to properly release those resources.

@kmossco
Copy link
Contributor

kmossco commented Jul 7, 2018

Thank you for this, we are right now prioritising adding feature parity to our API and then we will be working to actually move to asynchronously requests which may solve this problem at once. But happy to review any PR in the meantime if you have the time to create one. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants