Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition pattern rending pipe HTML code #313

Open
nomasprime opened this issue Nov 2, 2016 · 1 comment
Open

Definition pattern rending pipe HTML code #313

nomasprime opened this issue Nov 2, 2016 · 1 comment

Comments

@nomasprime
Copy link
Contributor

nomasprime commented Nov 2, 2016

Hi, I'm having a problem with using a pattern matcher inside a definition.

When I use "pattern": "string|image" it renders pattern: string|image

It looks like commit 6a84c67 might be causing the problem, i.e., renders fine with <code></code> instead of back ticks but I'm not sure why this change was made so maybe I'm doing something wrong my end.

Happy to create a PR to stop pipe being replaced with HTML code if that's the correct fix.

@geemus
Copy link
Member

geemus commented Nov 9, 2016

Hey. I don't think the code vs backtick should make a difference (I think markdown treats both the same). But that line does have an explicit gsub of | to &#124; it looks like. Probably some reason for having done that, but I do not remember it... Since we wrap it in code, maybe we can remove the gsub now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants